Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vecgeom from toolfiles #6370

Merged
merged 1 commit into from Nov 6, 2020
Merged

Remove vecgeom from toolfiles #6370

merged 1 commit into from Nov 6, 2020

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Nov 4, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_2_X/geant4.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Nov 4, 2020 •
edited

abort
lets remove it as in REL/CMSSW_11_1_0_pre4_GEANT4/slc7_amd64_gcc820...0e77e8e

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Jenkins tests are aborted.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Pull request #6370 was updated.

@mrodozov
Copy link
Contributor Author

mrodozov commented Nov 4, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

-1

Tested at: 980d3b6

CMSSW: CMSSW_11_2_GEANT4_X_2020-11-03-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87bb38/10497/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

The relvals timed out after 4 hours.

  • AddOn:

I found errors in the following addon tests:

Preparing to run ['cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVAddOnTest might have timed out: FAILED - secs

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Comparison job queued.

@mrodozov
Copy link
Contributor Author

mrodozov commented Nov 6, 2020 •
edited

@smuzaffar we need this to remove any reference to vecgeom, any objection I merge it and build a geant IB ?

@smuzaffar
Copy link
Contributor

@mrodozov , changes in vectorization/cmsdist_packages.py are not necessary. Please revert those.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

Pull request #6370 was updated.

@smuzaffar smuzaffar merged commit bca9016 into IB/CMSSW_11_2_X/geant4 Nov 6, 2020
@mrodozov mrodozov deleted the remove-vecgeom-geant4 branch November 6, 2020 16:43
@mrodozov mrodozov mentioned this pull request Nov 8, 2020
Closed
@cmsbuild cmsbuild mentioned this pull request Jan 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending externals-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrodozov @cmsbuild @smuzaffar