Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new root tools for histpainter and imt #6533

Merged
merged 1 commit into from Jan 6, 2021

Conversation

smuzaffar
Copy link
Contributor

This PR added two new root tools

  • HistPainter
  • Imt
    CMSSW UBSAN IBs failed to build due to missing linkage to HistPainter library. We propose to add these tools and then update cmssw/CondCore/SiStripPlugins/plugins to depend on HistPainter

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_3_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test
FYI @Dr15Jones and @makortel

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72f84e/11992/summary.html
COMMIT: be8661c
CMSSW: CMSSW_11_3_X_2021-01-05-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716944
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@smuzaffar smuzaffar merged commit 61d66e1 into IB/CMSSW_11_3_X/master Jan 6, 2021
@smuzaffar smuzaffar deleted the root-tools branch January 6, 2021 18:10
@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants