draft hepmc with cmake; cleanup old patches #6725

davidlange6 · 2021-03-12T11:17:12Z

Needs to be updated with the correct repository when cms-externals/hepmc#2 is merged.

cmsbuild · 2021-03-12T11:17:33Z

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_3_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

smuzaffar · 2021-03-12T11:24:27Z

please test

mrodozov · 2021-03-12T11:54:51Z

you can use cms-externals/hepmc#2 as additional PR here and keep the default source
please test with cms-externals/hepmc#2 should work

davidlange6 · 2021-03-12T12:13:44Z

Hum, good to know - but how does this predict the commit hash?

…

On Mar 12, 2021, at 12:55 PM, Mircho Rodozov ***@***.***> wrote: you can use cms-externals/hepmc#2 as additional PR here and keep the default source please test with cms-externals/hepmc#2 should work — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

cmsbuild · 2021-03-12T12:32:52Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbef3/13460/summary.html
COMMIT: 8a97caa
CMSSW: CMSSW_11_3_X_2021-03-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6725/13460/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

++ find /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/rivet/3.1.3-bb99b5e96130c8747435464638dcd50e -name config.guess
++ find /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/rivet/3.1.3-bb99b5e96130c8747435464638dcd50e -name config.sub
+ case slc7_amd64_gcc900 in
+ autoreconf -fiv
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Z8zgBu: line 74: autoreconf: command not found
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Z8zgBu (%prep)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Z8zgBu (%prep)

davidlange6 · 2021-03-12T12:48:28Z

looks like rivet was missing a build requires dependency on auto tools

cmsbuild · 2021-03-12T12:48:29Z

Pull request #6725 was updated.

davidlange6 · 2021-03-12T12:48:39Z

please test

cmsbuild · 2021-03-12T13:18:38Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbef3/13462/summary.html
COMMIT: 9b906ba
CMSSW: CMSSW_11_3_X_2021-03-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6725/13462/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ '[' 0 -ne 0 ']'
+ cd SHERPA-MC-2.2.11
+ chmod -Rf a+rX,u+w,g-w,o-w .
+ autoreconf -i --force
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.0jVJFl: line 42: autoreconf: command not found
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.0jVJFl (%prep)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.0jVJFl (%prep)

davidlange6 · 2021-03-12T14:09:49Z

please test

cmsbuild · 2021-03-12T14:10:02Z

Pull request #6725 was updated.

davidlange6 · 2021-03-15T14:44:23Z

Ok, so my “fix” will work… it would be nice to eventually keep the so libs too..

…

On Mar 15, 2021, at 3:28 PM, Malik Shahzad Muzaffar ***@***.***> wrote: @davidlange6 , yes look like hepmc_ is not defined for even existing hepmc build but as we only have static libs so when we link hepmc in to cmssw then we only link the functions we use in cmssw. That is why we do not see these errors in our existing build. linking against shared libs is different story, one need to have all function defined (even if you never call them). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

mrodozov · 2021-03-15T15:07:12Z

Hum, good to know - but how does this predict the commit hash?

I don't think it's predicting what it does is to get the PR branch head, and in this case the commit will be the PR head.

19:27:10 + pushd llvm-project
19:27:10 + git pull git://github.com/cms-externals/llvm-project.git gartung-esrgetcheck
19:27:11 From git://github.com/cms-externals/llvm-project
19:27:11  * branch            gartung-esrgetcheck -> FETCH_HEAD
19:27:13 Checking out files:  40% (2/5)   
Checking out files:  60% (3/5)   
Checking out files:  80% (4/5)   
Checking out files: 100% (5/5)   
Checking out files: 100% (5/5), done.
19:27:14 Updating 9ac43ce..18f656c
19:27:14 Fast-forward
19:27:14  clang-tools-extra/clang-tidy/cms/CMSTidyModule.cpp |  3 +
19:27:14  clang-tools-extra/clang-tidy/cms/CMakeLists.txt    |  3 +-
19:27:14  .../clang-tidy/cms/ESRecordGetCheck.cpp            | 91 ++++++++++++++++++++
19:27:14  .../clang-tidy/cms/ESRecordGetCheck.h              | 40 +++++++++
19:27:14  .../checkers/cms-eventsetuprecord-get.cpp          | 99 ++++++++++++++++++++++
19:27:14  5 files changed, 235 insertions(+), 1 deletion(-)
19:27:14  create mode 100644 clang-tools-extra/clang-tidy/cms/ESRecordGetCheck.cpp
19:27:14  create mode 100644 clang-tools-extra/clang-tidy/cms/ESRecordGetCheck.h
19:27:14  create mode 100644 clang-tools-extra/test/clang-tidy/checkers/cms-eventsetuprecord-get.cpp

you can see this PR that's still open:
cms-externals/llvm-project#10
I never had to read it (how it works) which means it works pretty well :D

smuzaffar · 2021-03-15T15:12:52Z

cmsBuild instead of downloading the sources using the url in spec, it just clone the external repo , go to the PR base branch and merge the PR changes and then use that cloned directory as downloaded sources. So yes, for externals coming from our github external repo, one can just open a PR for external and directly run tests without cmsdist PR.

cmsbuild · 2021-03-15T18:58:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbef3/13518/summary.html
COMMIT: 867b9aa
CMSSW: CMSSW_11_3_X_2021-03-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6725/13518/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2635087
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2635064
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files

davidlange6 · 2021-03-16T07:40:46Z

so I propose we merge cms-externals/hepmc#2

cmsbuild · 2021-03-16T07:48:53Z

Pull request #6725 was updated.

cmsbuild · 2021-03-16T07:49:30Z

Pull request #6725 was updated.

smuzaffar · 2021-03-16T07:50:19Z

please test

davidlange6 · 2021-03-16T07:58:59Z

cool - thanks @smuzaffar

cmsbuild · 2021-03-16T14:45:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbef3/13532/summary.html
COMMIT: 74c6ca7
CMSSW: CMSSW_11_3_X_2021-03-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6725/13532/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2635087
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2635062
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

smuzaffar · 2021-03-16T14:47:50Z

+externals

cmsbuild · 2021-03-16T14:48:09Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2021-03-16T14:52:26Z

@davidlange6 , I guess now we need https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_3_X/rootmodule/clhep-toolfile.spec#L29 and https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_3_X/rootmodule/clhep-toolfile.spec#L33 like changes for hepmc-toolfile for rootmodule branch ... right?

davidlange6 · 2021-03-16T14:57:17Z

Yes. I’ll take care of that ~tomorrow after seeing that these changes are ok

…

On Mar 16, 2021, at 3:52 PM, Malik Shahzad Muzaffar ***@***.***> wrote: @davidlange6 , I guess now we need https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_3_X/rootmodule/clhep-toolfile.spec#L29 and https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_3_X/rootmodule/clhep-toolfile.spec#L33 like changes for hepmc-toolfile for rootmodule branch ... right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

draft hepmc with cmake; cleanup old patches

8a97caa

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Mar 12, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 12, 2021

cmsbuild added tests-rejected and removed tests-started labels Mar 12, 2021

add autotools to rivet buildrequires

9b906ba

cmsbuild added tests-pending and removed tests-rejected labels Mar 12, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 12, 2021

cmsbuild added tests-rejected and removed tests-started labels Mar 12, 2021

needs autotools

9f6d685

cmsbuild added tests-started and removed tests-rejected labels Mar 12, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 15, 2021

smuzaffar mentioned this pull request Mar 16, 2021

Add module map to hepmc cms-externals/hepmc#2

Merged

Update hepmc.spec

1fee9d0

cmsbuild added tests-pending and removed tests-approved labels Mar 16, 2021

Update hepmc.spec

74c6ca7

cmsbuild added tests-started and removed tests-pending labels Mar 16, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 16, 2021

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Mar 16, 2021

smuzaffar merged commit f868222 into cms-sw:IB/CMSSW_11_3_X/master Mar 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

draft hepmc with cmake; cleanup old patches #6725

draft hepmc with cmake; cleanup old patches #6725

davidlange6 commented Mar 12, 2021

cmsbuild commented Mar 12, 2021

smuzaffar commented Mar 12, 2021

mrodozov commented Mar 12, 2021

davidlange6 commented Mar 12, 2021 via email

cmsbuild commented Mar 12, 2021

davidlange6 commented Mar 12, 2021

cmsbuild commented Mar 12, 2021

davidlange6 commented Mar 12, 2021

cmsbuild commented Mar 12, 2021

davidlange6 commented Mar 12, 2021

cmsbuild commented Mar 12, 2021

davidlange6 commented Mar 15, 2021 via email

mrodozov commented Mar 15, 2021

smuzaffar commented Mar 15, 2021

cmsbuild commented Mar 15, 2021

davidlange6 commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

davidlange6 commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

davidlange6 commented Mar 16, 2021 via email

draft hepmc with cmake; cleanup old patches #6725

draft hepmc with cmake; cleanup old patches #6725

Conversation

davidlange6 commented Mar 12, 2021

cmsbuild commented Mar 12, 2021

smuzaffar commented Mar 12, 2021

mrodozov commented Mar 12, 2021

davidlange6 commented Mar 12, 2021 via email

cmsbuild commented Mar 12, 2021

External Build

davidlange6 commented Mar 12, 2021

cmsbuild commented Mar 12, 2021

davidlange6 commented Mar 12, 2021

cmsbuild commented Mar 12, 2021

External Build

davidlange6 commented Mar 12, 2021

cmsbuild commented Mar 12, 2021

davidlange6 commented Mar 15, 2021 via email

mrodozov commented Mar 15, 2021

smuzaffar commented Mar 15, 2021

cmsbuild commented Mar 15, 2021

Comparison Summary

davidlange6 commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

davidlange6 commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

Comparison Summary

smuzaffar commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

davidlange6 commented Mar 16, 2021 via email