Update to new version; add new prometheus version; add aps tools #6731

vkuznet · 2021-03-15T15:03:32Z

No description provided.

cmsbuild · 2021-03-15T15:03:57Z

A new Pull Request was created by @vkuznet (Valentin Kuznetsov) for branch IB/CMSSW_11_3_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

mrodozov · 2021-03-15T16:46:37Z

please test

cmsbuild · 2021-03-15T17:07:45Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f72b28/13527/summary.html
COMMIT: 9d71ed1
CMSSW: CMSSW_11_3_X_2021-03-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6731/13527/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ for cmd in monit ggus_parser alert annotationManager nats-sub nats-pub nats-exitcodes-termui dbs_vm
+ cp nats-pub /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/56e556f66f587e5ed816e7a6e2be0067/opt/cmssw/slc7_amd64_gcc900/cms/cmsmon-tools/0.5.27-56e556f66f587e5ed816e7a6e2be0067/
+ for cmd in monit ggus_parser alert annotationManager nats-sub nats-pub nats-exitcodes-termui dbs_vm
+ cp nats-exitcodes-termui /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/56e556f66f587e5ed816e7a6e2be0067/opt/cmssw/slc7_amd64_gcc900/cms/cmsmon-tools/0.5.27-56e556f66f587e5ed816e7a6e2be0067/
cp: cannot stat 'nats-exitcodes-termui': No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.VKDq5g (%install)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.VKDq5g (%install)

smuzaffar · 2021-03-15T17:10:47Z

cmsmon-tools.spec

@@ -60,6 +61,14 @@ chmod +x stern_linux_amd64
 cp stern_linux_amd64 %i/stern
 cd -

+# install token-manager
+cd %{_builddir}
+curl -ksLO https://github.com/vkuznet/auth-proxy-server/releases/download/%apsver/auth-proxy-tools.tar.gz


@vkuznet , why not add this to sources?

Shahzad, honestly I don't remember RPM spec command syntax, and I find it very difficult to find the appropriate docs for them. The setup syntax I obviously don't remember, e.g. how it untar/unzip all possible combinations, and it is much easier to call curl instead of using sources/setup. If you remember proper syntax feel free to let me know how to do it (I can't do man rpm synax, and googling rpm setup does not lead anywhere close to how RPM commands are structured and which options to use for different use-cases).

I mean you already have 4 sources defined here https://github.com/cms-sw/cmsdist/pull/6731/files#diff-15398a788af5b8c0e165e8cca9a44fb7637daebb4850bf66571da9512729a925L11-L14 , so why not just and this as a Source4 and extract is just like you extract other sources https://github.com/cms-sw/cmsdist/pull/6731/files#diff-15398a788af5b8c0e165e8cca9a44fb7637daebb4850bf66571da9512729a925L24

by the way the RPM doc here https://rpm-packaging-guide.github.io/ looks good. See the %setup section for details how to expand

cmsbuild · 2021-03-15T17:33:37Z

Pull request #6731 was updated.

smuzaffar · 2021-03-16T07:02:41Z

please test

cmsbuild · 2021-03-16T09:23:31Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f72b28/13531/summary.html
COMMIT: 7246499
CMSSW: CMSSW_11_3_X_2021-03-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6731/13531/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/cms/cmsmon-tools/0.5.27-cbad6107ee34e75340e687369e7f4ca1
+ curl -ksLO https://github.com/vkuznet/auth-proxy-server/releases/download/0.1.85/auth-proxy-tools.tar.gz
+ tar xfz auth-proxy-tools.tar.gz
+ cp token-manager /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/cbad6107ee34e75340e687369e7f4ca1/opt/cmssw/slc7_amd64_gcc900/cms/cmsmon-tools/0.5.27-cbad6107ee34e75340e687369e7f4ca1/
cp: cannot stat 'token-manager': No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.TMu3vj (%install)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.TMu3vj (%install)

cmsbuild · 2021-03-16T12:07:12Z

Pull request #6731 was updated.

vkuznet · 2021-03-16T12:09:59Z

@smuzaffar I added sources, but for Source4 which is not a tarball I have no idea how to deal with it in rpm macro world. I also don't know how to refer to it if I call curl. Once again RedHat docs are not helpful and search for "how to download source file in rpm" or similar queires does not lead to what I need to know. If you know how to force in prep step a download of given source please let me know and I'll be happy to adjust the spec, otherwise for stern tool (which is just executable we need to download) I left the curl approach.

vkuznet · 2021-03-16T12:10:33Z

otherwise, the build is fine now in my local area. Please test it.

cmsbuild · 2021-03-16T12:34:49Z

Pull request #6731 was updated.

smuzaffar · 2021-03-16T12:35:41Z

@vkuznet , I have fixed the source4. For such files you can use %{_sourcedir} to access the downloaded file

smuzaffar · 2021-03-16T12:35:49Z

please test

vkuznet · 2021-03-16T12:49:04Z

thanks, I'll keep this in mind for other specs as we may have more and more just static executables from go tools.

smuzaffar · 2021-03-16T16:34:08Z

+externals

cmsbuild · 2021-03-16T16:34:31Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_3_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2021-03-16T18:07:45Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f72b28/13544/summary.html
COMMIT: b97d43f
CMSSW: CMSSW_11_3_X_2021-03-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6731/13544/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2635087
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2635062
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

Update to new version; add new prometheus version; add aps tools

9d71ed1

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Mar 15, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 15, 2021

cmsbuild added tests-rejected and removed tests-started labels Mar 15, 2021

smuzaffar reviewed Mar 15, 2021

View reviewed changes

remove nats-exitcodes-termui

7246499

cmsbuild removed the tests-rejected label Mar 15, 2021

cmsbuild added the tests-pending label Mar 15, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 16, 2021

cmsbuild added tests-rejected and removed tests-started labels Mar 16, 2021

Fix build

8894911

cmsbuild added tests-pending and removed tests-rejected labels Mar 16, 2021

fix stern

b97d43f

cmsbuild added tests-started and removed tests-pending labels Mar 16, 2021

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Mar 16, 2021

smuzaffar merged commit aff52bd into cms-sw:IB/CMSSW_11_3_X/master Mar 16, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to new version; add new prometheus version; add aps tools #6731

Update to new version; add new prometheus version; add aps tools #6731

vkuznet commented Mar 15, 2021

cmsbuild commented Mar 15, 2021

mrodozov commented Mar 15, 2021

cmsbuild commented Mar 15, 2021

smuzaffar Mar 15, 2021

vkuznet Mar 15, 2021

smuzaffar Mar 16, 2021 •

edited

smuzaffar Mar 16, 2021

cmsbuild commented Mar 15, 2021

smuzaffar commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

vkuznet commented Mar 16, 2021

vkuznet commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

vkuznet commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

Update to new version; add new prometheus version; add aps tools #6731

Update to new version; add new prometheus version; add aps tools #6731

Conversation

vkuznet commented Mar 15, 2021

cmsbuild commented Mar 15, 2021

mrodozov commented Mar 15, 2021

cmsbuild commented Mar 15, 2021

External Build

smuzaffar Mar 15, 2021

Choose a reason for hiding this comment

vkuznet Mar 15, 2021

Choose a reason for hiding this comment

smuzaffar Mar 16, 2021 • edited

Choose a reason for hiding this comment

smuzaffar Mar 16, 2021

Choose a reason for hiding this comment

cmsbuild commented Mar 15, 2021

smuzaffar commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

External Build

cmsbuild commented Mar 16, 2021

vkuznet commented Mar 16, 2021

vkuznet commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

vkuznet commented Mar 16, 2021

smuzaffar commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

cmsbuild commented Mar 16, 2021

Comparison Summary

smuzaffar Mar 16, 2021 •

edited