Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove root_numpy and root_pandas on cmsdist master" #6911

Merged

Conversation

mrodozov
Copy link
Contributor

Reverts #6896

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

#6896 (comment)

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-412b9e/15127/summary.html
COMMIT: e3eaad7
CMSSW: CMSSW_12_0_X_2021-05-16-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6911/15127/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-412b9e/15127/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-412b9e/15127/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648242
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2648219
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@mrodozov mrodozov merged commit 8263e75 into IB/CMSSW_12_0_X/master May 17, 2021
@mrodozov mrodozov deleted the revert-6896-remove-root-numpy-pandas branch May 17, 2021 07:05
@jfernan2
Copy link

Thanks @mrodozov !
Do you know of any alternative to root_numpy that we could use instead so that root_numpy may be dropped?

@davidlange6
Copy link
Contributor

davidlange6 commented May 17, 2021 via email

@jfernan2
Copy link

jfernan2 commented May 17, 2021

Thanks @davidlange6
uproot was not even necessary
cms-sw/cmssw#33751

@mrodozov
Copy link
Contributor Author

well that was quick :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants