Triton: enable GPU support #6929

kpedro88 · 2021-05-20T22:56:11Z

The Triton client must be compiled with GPU support enabled in order to use GPU shared memory (via the cudaIpcMemHandle_t object).

cmsbuild · 2021-05-20T22:56:36Z

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

mrodozov · 2021-05-20T23:10:33Z

please test

cmsbuild · 2021-05-21T05:30:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8e705/15223/summary.html
COMMIT: 2eb7f15
CMSSW: CMSSW_12_0_X_2021-05-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6929/15223/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650457
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-05-25T00:07:46Z

Pull request #6929 was updated.

kpedro88 · 2021-05-25T00:17:56Z

please test

cmsbuild · 2021-05-25T00:42:04Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8e705/15279/summary.html
COMMIT: b26e52e
CMSSW: CMSSW_12_0_X_2021-05-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6929/15279/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

# Do not package libtool and archive libraries, unless required.
# Dont' need archive libraries.
sed: can't read need: No such file or directory
sed: can't read archive: No such file or directory
sed: can't read libraries.: No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.p2rnAX (%install)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.p2rnAX (%install)

cmsbuild · 2021-05-25T01:28:14Z

Pull request #6929 was updated.

kpedro88 · 2021-05-25T01:28:44Z

please test

fwyzard · 2021-05-26T07:48:00Z

@smuzaffar this approach leaves the

Requires: cuda

dependency, though ?

Isn't that a problem for an installation where CUDA is not available ?

kpedro88 · 2021-05-26T14:19:25Z

please test

cmsbuild · 2021-05-26T17:51:12Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8e705/15327/summary.html
COMMIT: f88ebf5
CMSSW: CMSSW_12_0_X_2021-05-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6929/15327/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650457
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-05-30T19:36:32Z

Pull request #6929 was updated.

mrodozov · 2021-05-30T19:37:20Z

please test
openssl removal created conflicts

mrodozov · 2021-05-30T19:38:34Z

@kpedro88 @fwyzard we merge this as it is and continue on the flags topic additionally, correct ?

cmsbuild · 2021-05-30T23:07:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8e705/15434/summary.html
COMMIT: 93daea9
CMSSW: CMSSW_12_0_X_2021-05-30-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6929/15434/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Update tag for PhysicsTools-PatUtils to V00-03-00 #6938 @cms-sw: Update tag for PhysicsTools-PatUtils to V00-03-00
New dasgoclient version #6945 @vkuznet: New dasgoclient version

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8e705/15434/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8e705/15434/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2650457
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

mrodozov · 2021-05-31T11:55:10Z

+externals

cmsbuild · 2021-05-31T11:55:34Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

kpedro88 · 2021-06-01T13:57:39Z

@mrodozov yes, from my side this is ready to go.

smuzaffar · 2021-06-01T14:04:47Z

@smuzaffar this approach leaves the
Requires: cuda
dependency, though ?

Isn't that a problem for an installation where CUDA is not available ?

@fwyzard , we can not avoid this. For archs where cuda is not available, we can just provide a dummy cuda.spec

fwyzard · 2021-06-01T14:17:07Z

That is why I was suggesting to implement it as a specfile macro that could be used with %if .

Anyway, this is a more general comment, which should not block this PR.

Triton: enable GPU support

2eb7f15

kpedro88 mentioned this pull request May 20, 2021

shared memory support for SonicTriton cms-sw/cmssw#33801

Merged

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels May 20, 2021

cmsbuild added tests-started and removed tests-pending labels May 20, 2021

cmsbuild added tests-approved tests-pending and removed tests-started tests-approved labels May 21, 2021

cmsbuild added tests-started and removed tests-pending labels May 25, 2021

cmsbuild added tests-rejected and removed tests-started labels May 25, 2021

enforce GPU macro

1bc75bd

kpedro88 force-pushed the TritonGPU120X branch from b26e52e to 1bc75bd Compare May 25, 2021 01:27

cmsbuild added tests-pending and removed tests-rejected labels May 25, 2021

cmsbuild added tests-started and removed tests-pending labels May 25, 2021

cmsbuild added tests-started and removed tests-pending labels May 26, 2021

cmsbuild added tests-approved and removed tests-started labels May 26, 2021

kpedro88 mentioned this pull request May 26, 2021

Add shared memory options fastmachinelearning/SonicCMS#21

Closed

Merge branch 'IB/CMSSW_12_0_X/master' into TritonGPU120X

93daea9

cmsbuild added tests-pending and removed tests-approved labels May 30, 2021

cmsbuild added tests-started and removed tests-pending labels May 30, 2021

cmsbuild added tests-approved and removed tests-started labels May 30, 2021

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels May 31, 2021

smuzaffar merged commit 5694dc8 into cms-sw:IB/CMSSW_12_0_X/master Jun 2, 2021

cmsbuild mentioned this pull request Jun 3, 2021

Update eigen, get omitted commit #6971

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Triton: enable GPU support #6929

Triton: enable GPU support #6929

kpedro88 commented May 20, 2021

cmsbuild commented May 20, 2021

mrodozov commented May 20, 2021

cmsbuild commented May 21, 2021

cmsbuild commented May 25, 2021

kpedro88 commented May 25, 2021

cmsbuild commented May 25, 2021

cmsbuild commented May 25, 2021

kpedro88 commented May 25, 2021

fwyzard commented May 26, 2021 •

edited

kpedro88 commented May 26, 2021

cmsbuild commented May 26, 2021

cmsbuild commented May 30, 2021

mrodozov commented May 30, 2021

mrodozov commented May 30, 2021

cmsbuild commented May 30, 2021

mrodozov commented May 31, 2021

cmsbuild commented May 31, 2021

kpedro88 commented Jun 1, 2021

smuzaffar commented Jun 1, 2021

fwyzard commented Jun 1, 2021

Navigation Menu

Triton: enable GPU support #6929

Triton: enable GPU support #6929

Conversation

kpedro88 commented May 20, 2021

cmsbuild commented May 20, 2021

mrodozov commented May 20, 2021

cmsbuild commented May 21, 2021

Comparison Summary

cmsbuild commented May 25, 2021

kpedro88 commented May 25, 2021

cmsbuild commented May 25, 2021

External Build

cmsbuild commented May 25, 2021

kpedro88 commented May 25, 2021

fwyzard commented May 26, 2021 • edited

kpedro88 commented May 26, 2021

cmsbuild commented May 26, 2021

Comparison Summary

cmsbuild commented May 30, 2021

mrodozov commented May 30, 2021

mrodozov commented May 30, 2021

cmsbuild commented May 30, 2021

Comparison Summary

mrodozov commented May 31, 2021

cmsbuild commented May 31, 2021

kpedro88 commented Jun 1, 2021

smuzaffar commented Jun 1, 2021

fwyzard commented Jun 1, 2021

fwyzard commented May 26, 2021 •

edited