move pybind11 to python3 only #6996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…will be done as a follow-on PR as it also involves cmssw changes
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/master. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
|
please test |
|
the test is failing, I think it's scram (or something scram doesn't read as expected) |
|
Thanks for the heads up - I guess I should build the entire stack to debug this - I realize that I probably needed to add a python2 requirement to py2-pybind11-toolfile.
… On Jun 8, 2021, at 2:15 PM, Mircho Rodozov ***@***.***> wrote:
the test is failing, I think it's scram:
13:09:38 Name : py2-pybind11
13:09:38 Traceback (most recent call last):
13:09:38 File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/share/lcg/SCRAMV1/V3_00_23/bin/scram.py", line 114, in <module>
13:09:38 main()
13:09:38 File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/share/lcg/SCRAMV1/V3_00_23/bin/scram.py", line 109, in main
13:09:38 if not execcommand(args, opts):
13:09:38 File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/share/lcg/SCRAMV1/V3_00_23/bin/scram.py", line 103, in execcommand
13:09:38 return eval('scram_commands.cmd_%s' % cmds[0])(args, opts)
13:09:38 File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/share/lcg/SCRAMV1/V3_00_23/SCRAM/Core/CMD.py", line 43, in cmd_setup
13:09:38 return process(args)
13:09:38 File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/share/lcg/SCRAMV1/V3_00_23/SCRAM/Core/Commands/setup.py", line 60, in process
13:09:38 toolmanager.setupalltools()
13:09:38 File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/share/lcg/SCRAMV1/V3_00_23/SCRAM/BuildSystem/ToolManager.py", line 64, in setupalltools
13:09:38 self.coresetup(toolfile, dump)
13:09:38 File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/share/lcg/SCRAMV1/V3_00_23/SCRAM/BuildSystem/ToolManager.py", line 86, in coresetup
13:09:38 self._update_json(tooljson, dump)
13:09:38 File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/share/lcg/SCRAMV1/V3_00_23/SCRAM/BuildSystem/ToolManager.py", line 113, in _update_json
13:09:38 printmsg("Version : %s" % self.xml.contents['TOOLVERSION'])
13:09:38 KeyError: 'TOOLVERSION'
13:09:38 + ERR=1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
smuzaffar
reviewed
Jun 8, 2021
py2-pybind11-toolfile.spec
Outdated
| @@ -1,5 +1,5 @@ | |||
| ### RPM external py2-pybind11-toolfile 1.0 | |||
There was a problem hiding this comment.
@davidlange6 , rename the spec to py3-pybind11.spec and also update the name in the line above
|
@davidlange6 , as cmsRun still uses py2, so we will still need the py2-pybind11 |
|
I don’t think so - Pybind11 is just headers.. notice that we use py2-pybind11 for both the py2 and py3 cmsRuns currently (an oversight..)
… On Jun 8, 2021, at 2:24 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
@davidlange6 , as cmsRun still uses py2, so we will still need the py2-pybind11
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
please test (I'm building cmssw locally as well - but it seems better now) |
|
Pull request #6996 was updated. |
|
@davidlange6 , did you see my comment https://github.com/cms-sw/cmsdist/pull/6996/files#r647386284 ? the toolfile name and package name should match. if package is called py3-pybind11 then toolfile spec should be py3-pybind11-toolfile otherwise the logic https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_12_0_X/master/scram-tools-post.file#L4-L7 fails |
|
ok, no - I didn't. - I'll abort and find another approach. |
|
please abort |
|
Pull request #6996 was updated. |
|
this will be tested with cmssw changes in #34026.. |
smuzaffar
reviewed
Jun 8, 2021
py3-pybind11-toolfile.spec
Outdated
| %install | ||
|
|
||
| mkdir -p %{i}/etc/scram.d | ||
| cat << \EOF_TOOLFILE >%{i}/etc/scram.d/py2-pybind11.xml |
There was a problem hiding this comment.
@davidlange6 , please also update the xml file name. It should be py3-pybind11.xml
|
Argh - I missed that -sorry
… On Jun 8, 2021, at 4:51 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
@smuzaffar commented on this pull request.
In py3-pybind11-toolfile.spec:
> @@ -0,0 +1,22 @@
+### RPM external py3-pybind11-toolfile 1.0
+Requires: py3-pybind11
+
+%prep
+
+%build
+
+%install
+
+mkdir -p %{i}/etc/scram.d
+cat << \EOF_TOOLFILE >%{i}/etc/scram.d/py2-pybind11.xml
@davidlange6 , please also update the xml file name. It should be py3-pybind11.xml
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Pull request #6996 was updated. |
|
please test |
|
Will fail if its not tested with the cmssw changes.. (I think I started those tests)
… On Jun 8, 2021, at 6:47 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
please test
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb9d93/15767/summary.html Comparison SummarySummary:
|
|
tested with cms-sw/cmssw#34026 |
|
+1 |
|
merge |
This was referenced Jun 16, 2021
Merged
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes advantage of pybind11 being used as a header only package having only a loose connection to python version. The pybind11 toolfile should be renamed. This will be done as a follow-on PR as it also involves cmssw changes