Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue with removing python2 versions #7008

Merged
merged 5 commits into from Jun 10, 2021

Conversation

smuzaffar
Copy link
Contributor

backported from DEVEL IBs

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

@davidlange6 , can you please fix pip/requirement.txt file. last night I updated pillow and that is now creating conflicts with this PR. just update

pillow==8.2.0 ; python_version>'3.0'

in your branch

@cmsbuild
Copy link
Contributor

Pull request #7008 was updated.

@cmsbuild
Copy link
Contributor

Pull request #7008 was updated.

@davidlange6
Copy link
Contributor

hum, I think I got it..

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Jun 10, 2021

test parameters:

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Jun 10, 2021

@davidlange6 , in your next round, please

  • drop py2-Pygments , it was only used by DXR but DXR is now pyY3 only.
  • drop py2-pillow, it is only required by bokeh which we only build for py3

This should fix the 2 security issue https://github.com/cms-sw/cmsdist/security/dependabot

@davidlange6
Copy link
Contributor

davidlange6 commented Jun 10, 2021 via email

@smuzaffar
Copy link
Contributor Author

please test
restart the tests with cms-sw/cms-bot#1562 which should allow to run clang, static analysis , py3, code rules on cmssw PRs only instead of full cmssw. Hopefully this save some PR test time

@smuzaffar
Copy link
Contributor Author

please test
restarted after fixing the test parameters

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4261f3/15860/summary.html
COMMIT: 13ed469
CMSSW: CMSSW_12_0_X_2021-06-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7008/15860/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4261f3/15860/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4261f3/15860/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2862491
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 3161cb9 into cms-sw:IB/CMSSW_12_0_X/master Jun 10, 2021
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants