Get catch2 2.13.6

[mrodozov]

Resolves: #7052

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

Pull request #7053 was updated.

[mrodozov]

please test

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-227422/16148/summary.html
COMMIT: 4c18de3
CMSSW: CMSSW_12_0_X_2021-06-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7053/16148/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

[mrodozov]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-227422/16149/summary.html
COMMIT: c1d9e32
CMSSW: CMSSW_12_0_X_2021-06-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7053/16149/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-21-1100/src/FWCore/Framework/test/test_catch2_main.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-21-1100/src/FWCore/Framework/test/test_catch2notTP_ESRecordsToProxyIndices.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-21-1100/src/FWCore/Framework/test/test_catch2notTP_MergeableRunProductMetadata.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-21-1100/src/FWCore/Framework/test/test_catch2notTP_ESRecordsToProxyIndices.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-21-1100/src/FWCore/Framework/test/test_catch2notTP_ESRecordsToProxyIndices.cc: In function 'void ____C_A_T_C_H____T_E_S_T____0()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-21-1100/src/FWCore/Framework/test/test_catch2notTP_ESRecordsToProxyIndices.cc:87:23: error: comparison of integer expressions of different signedness: 'unsigned int' and 'edm::ESProxyIndex::Value_t' {aka 'int'} [-Werror=sign-compare]
   87 |         REQUIRE(index == r2pi.indexInRecord(pr.first, dk).value());
      |                 ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: some warnings being treated as errors
gmake: *** [tmp/slc7_amd64_gcc900/src/FWCore/Framework/test/TestFWCoreFrameworkCatch2notTP/test_catch2notTP_ESRecordsToProxyIndices.cc.o] Error 1
>> Building binary TestFWCoreFrameworkCatch2notTP


[smuzaffar]

please test with cms-sw/cmssw#34205

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-227422/16177/summary.html
COMMIT: c1d9e32
CMSSW: CMSSW_12_0_X_2021-06-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7053/16177/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• [TBB] Use another repo/branch/tag for PPC #7051 @cms-sw: [TBB] Use another repo/branch/tag for PPC
• restore pyyaml on python2 as needed by conddb  #7054 @davidlange6: restore pyyaml on python2 as needed by conddb
• [BuildRules] Fix the EDM_PLUGIN="0" flag in plugisn/BuildFile #7055 @cms-sw: [BuildRules] Fix the EDM_PLUGIN="0" flag in plugisn/BuildFile

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-227422/16177/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-227422/16177/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785631
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2785596
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals
this should be merged along with cms-sw/cmssw#34205

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[smuzaffar]

@mrodozov , looks like https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc900/CMSSW_12_0_X_2021-06-23-1600/DQM/TrackerRemapper also need changes due to catch2.

[smuzaffar]

the reason that PR tests did not catch this is that this was merged in a newer IB CMSSW_12_0_X_2021-06-22-2300 while the tests were run based on CMSSW_12_0_X_2021-06-22-1100

[smuzaffar]

OK I opened a PR cms-sw/cmssw#34230 to fix it