Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmssw-wm-tools.spec #7196

Merged
merged 2 commits into from Aug 3, 2021
Merged

Conversation

davidlange6
Copy link
Contributor

pick up the right python version based on what the cmssw fwk is using.

@smuzaffar - can you have a look at the changes and push to cvmfs if they look ok to you.
cms-sw/cmssw-wm-tools@dd83961

pick up the right python version based on what the cmssw fwk is using.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

Pull request #7196 was updated.

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

smuzaffar commented Aug 3, 2021

@davidlange6 , this looks good to me. Any objection on merging it and deploying it or you would like to wait for @amaltaro feedback?

@davidlange6
Copy link
Contributor Author

davidlange6 commented Aug 3, 2021 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd0840/17468/summary.html
COMMIT: c6e5158
CMSSW: CMSSW_12_1_X_2021-08-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7196/17468/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1299 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 3672
  • DQMHistoTests: Total nulls: 19
  • DQMHistoTests: Total successes: 2994851
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -45.703 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 52cabda into IB/CMSSW_12_1_X/master Aug 3, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants