Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Intel compiler: icpx #7728

Merged

Conversation

gartung
Copy link
Member

@gartung gartung commented Mar 28, 2022

The new Intel compiler uses llvm/clang as the backend. It no longer includes a fortran compiler.
Update icc version to the last version released/available on /cvmfs/projects.cern.ch/intelsw

@gartung
Copy link
Member Author

gartung commented Mar 28, 2022

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_12_4_X/master.

@smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Mar 28, 2022

@smuzaffar I tried building just the tool files on the CMSDIST/CMSSW_12_4_X/master branch
PKGTOOLS/cmsBuild -a slc7_amd64_gcc11 -i cmssw --weekly build cmssw-tool-conf
but this wants to rebuild everything. Is gcc11 not the production arch?

@smuzaffar
Copy link
Contributor

@gartung , IB/CMSSW_12_4_X/master is for gcc10 ( so use slc7_amd64_gcc10 arch arch)

@gartung
Copy link
Member Author

gartung commented Mar 28, 2022

please test

@gartung
Copy link
Member Author

gartung commented Mar 28, 2022

@smuzaffar Don't merge yet. I need to adjust flags.

@cmsbuild
Copy link
Contributor

Pull request #7728 was updated.

@cmsbuild
Copy link
Contributor

Pull request #7728 was updated.

@cmsbuild
Copy link
Contributor

Pull request #7728 was updated.

@gartung
Copy link
Member Author

gartung commented Mar 28, 2022

please test

@cmsbuild
Copy link
Contributor

Pull request #7728 was updated.

@gartung
Copy link
Member Author

gartung commented Mar 28, 2022

@smuzaffar For some reason everything is rebuilding.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/23462/console

@@ -1,3 +1,3 @@
<tool name="intel-license" version="@TOOL_VERSION@">
<runtime name="INTEL_LICENSE_FILE" value="28518@AT@lxlicen01.cern.ch,28518@AT@lxlicen02.cern.ch,28518@AT@lxlicen03.cern.ch" type="path" handler="warn"/>
<runtime name="INTEL_LICENSE_FILE" value="28518@AT@lxlicen01.cern.ch,28518@AT@lxlicen02.cern.ch,28518@AT@lxlicen03.cern.ch" type="var" handler="warn"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case just remove the type="path" part.

@smuzaffar
Copy link
Contributor

@smuzaffar For some reason everything is rebuilding. https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/23462/console

we have merged couple of externals after 11h00 IB, so all those externals and their dependencies are building

@cmsbuild
Copy link
Contributor

Pull request #7728 was updated.

@gartung
Copy link
Member Author

gartung commented Mar 29, 2022

please test

@cmsbuild
Copy link
Contributor

Pull request #7728 was updated.

@gartung
Copy link
Member Author

gartung commented Mar 29, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-663eb0/23508/summary.html
COMMIT: 6113a6e
CMSSW: CMSSW_12_4_X_2022-03-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7728/23508/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3585896
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3585866
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@gartung
Copy link
Member Author

gartung commented Mar 31, 2022

@smuzaffar

@smuzaffar
Copy link
Contributor

+externals
looks good

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2022

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants