New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spack] Update py-packages to the latest version #7767
[Spack] Update py-packages to the latest version #7767
Conversation
A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_12_4_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
pip/requirements.txt
Outdated
@@ -281,7 +281,7 @@ tenacity==8.0.1 | |||
#NO_AUTO_UPDATE:3: Force to use tensorflow 2.6.0; this should match the version in tensorflow-sources.spec | |||
tensorboard==2.6.0 | |||
tensorflow==2.6.0 | |||
tensorflow-estimator==2.6.0 | |||
tensorflow-estimator==2.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep this one at 2.6.0 as well, to match tensorflow. But could be wrong. @smuzaffar ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try the test for 2.6.0 (tensorflow latest version is also 2.8.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, we need to keep it to 2.6.0 (to match the version in tensorflow-sources
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Pull request #7767 was updated. |
please test |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-647cd0/23725/summary.html External BuildI found compilation error when building: warning: no files found matching 'README.rst' adding license file 'LICENSE' writing manifest file '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/py3-typing/3.10.0.0-d6543bedcddaf7b6b167af71c279f4bc/cmsdist-tmp/pip-pip-egg-info-ojkryc0o/typing.egg-info/SOURCES.txt' Preparing metadata (setup.py): finished with status 'done' ERROR: Package 'typing' requires a different Python: 3.9.6 not in '!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,<3.5,>=2.7' error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.z0hcA2 (%build) RPM build errors: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.z0hcA2 (%build) |
@@ -298,7 +298,7 @@ tqdm==4.62.2 | |||
traitlets==5.1.0 | |||
typed-ast==1.4.3 | |||
typing-extensions==3.10.0.2 | |||
typing==3.7.4.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we not drop py3-typing
some time ago? If not, we should:
NOTE: in Python 3.5 and later, the typing module lives in the stdlib, and installing this package has NO EFFECT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not remember such a change. Yes, we should drop it as it is picked up from python3 installations
[muzaffar@lxplus796 ~]$ source /cvmfs/cms.cern.ch/slc7_amd64_gcc10/external/py3-typing/3.7.4.3/etc/profile.d/init.sh
[muzaffar@lxplus796 ~]$ python3 -c 'import typing;print(typing.__file__)'
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/external/python3/3.8.2-llifpc/lib/python3.8/typing.py
@aandvalenzuela , can you please remove it from requirements.txt and also remove all of its usages e.g. https://github.com/cms-sw/cmsdist/search?q=py3-typing
Pull request #7767 was updated. |
please test |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-647cd0/23768/summary.html External BuildI found compilation error when building: + DEPS='py3-dill ' + '[' 'py3-dill ' '!=' '' ']' + echo 'ERROR: Missing dependencies for py3-pylint (python3) found: py3-dill ' ERROR: Missing dependencies for py3-pylint (python3) found: py3-dill + exit 1 error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.eOcZYq (%build) RPM build errors: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.eOcZYq (%build) |
@aandvalenzuela , I would suggest to try to build it locally first. These types of updates take too many iteration. In order to build locally you need to run following on cmsdev machines
you might get errors like the above |
Pull request #7767 was updated. |
please test |
Pull request #7767 was updated. |
Pull request #7767 was updated. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-647cd0/23799/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
please test for slc7_aarch64_gcc11 |
please test for slc7_ppc64le_gcc11 |
-1 Failed Tests: UnitTests RelVals The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test DRNTest had ERRORS ---> test testFWCoreUtilities had ERRORS ---> test TestFWCoreServicesDriver had ERRORS ---> test import-tables had ERRORS and more ... RelVals
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to go in
@aandvalenzuela , this looks good to go in, do you plan to update it ? |
No description provided.