Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to head of 1.6 branch to pick up fix for segfault in gdwarf. #7853

Merged
merged 2 commits into from May 11, 2022

Conversation

gartung
Copy link
Member

@gartung gartung commented May 10, 2022

Resolves cms-sw/cmssw#37816

Tested locally with same input used in cms-sw/cmssw#37816 that igprof runs without segfault in libunwind.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_12_4_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented May 10, 2022

please test

@cmsbuild
Copy link
Contributor

Pull request #7853 was updated.

@gartung
Copy link
Member Author

gartung commented May 10, 2022

@smuzaffar

@gartung
Copy link
Member Author

gartung commented May 10, 2022

please test

@smuzaffar
Copy link
Contributor

enable profiling

@smuzaffar
Copy link
Contributor

please test

@jpata
Copy link

jpata commented May 11, 2022

From the reco side, we would like to have this in pre4, to ensure we can profile the release (cc @clacaputo).

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1213e/24606/summary.html
COMMIT: aa43db0
CMSSW: CMSSW_12_4_X_2022-05-10-2300/slc7_amd64_gcc10
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7853/24606/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1213e/24606/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1213e/24606/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3696633
  • DQMHistoTests: Total failures: 313
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696298
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 74.93600000000002 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 9.367 KiB MTD/Vertices
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@gartung
Copy link
Member Author

gartung commented May 11, 2022

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 5b167e2 into cms-sw:IB/CMSSW_12_4_X/master May 11, 2022
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

igprof pp segfault in 12_3_0, 12_3_0_pre4 in the Run3 reco step
4 participants