Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporating murre tool under cmsmon-tools. #8236

Merged

Conversation

arooshap
Copy link

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arooshap (Aroosha Pervaiz) for branch IB/CMSSW_12_6_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84c602/29688/summary.html
COMMIT: f9bc2e6
CMSSW: CMSSW_12_6_X_2022-12-19-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8236/29688/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ chmod +x /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/6911f4098230bce7ed93042a317db43f/opt/cmssw/el8_amd64_gcc10/cms/cmsmon-tools/0.5.35-6911f4098230bce7ed93042a317db43f/gocurl
+ cd -
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc10/cms/cmsmon-tools/0.5.35-6911f4098230bce7ed93042a317db43f/trivy-0.21.1
+ cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc10/cms/cmsmon-tools/0.5.35-6911f4098230bce7ed93042a317db43f/murre-0.0.4/murre /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/6911f4098230bce7ed93042a317db43f/opt/cmssw/el8_amd64_gcc10/cms/cmsmon-tools/0.5.35-6911f4098230bce7ed93042a317db43f/murre
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.ERYvgD: line 80: cd: too many arguments
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.ERYvgD (%install)


RPM build errors:
line 36: It's not recommended to have unversioned Obsoletes: Obsoletes: cms+cmsmon-tools+0.5.35-6911f4098230bce7ed93042a317db43f
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.ERYvgD (%install)


@cmsbuild
Copy link
Contributor

Pull request #8236 was updated.

@aandvalenzuela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84c602/29689/summary.html
COMMIT: 2d4b5f7
CMSSW: CMSSW_12_6_X_2022-12-19-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8236/29689/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ chmod +x /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/3657e91c48abe0807b35ecf451829e66/opt/cmssw/el8_amd64_gcc10/cms/cmsmon-tools/0.5.35-3657e91c48abe0807b35ecf451829e66/gocurl
+ cd -
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc10/cms/cmsmon-tools/0.5.35-3657e91c48abe0807b35ecf451829e66/trivy-0.21.1
+ cp /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc10/cms/cmsmon-tools/0.5.35-3657e91c48abe0807b35ecf451829e66/murre-0.0.4/murre /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/3657e91c48abe0807b35ecf451829e66/opt/cmssw/el8_amd64_gcc10/cms/cmsmon-tools/0.5.35-3657e91c48abe0807b35ecf451829e66/murre
cp: cannot stat '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc10/cms/cmsmon-tools/0.5.35-3657e91c48abe0807b35ecf451829e66/murre-0.0.4/murre': No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.AE50vc (%install)


RPM build errors:
line 36: It's not recommended to have unversioned Obsoletes: Obsoletes: cms+cmsmon-tools+0.5.35-3657e91c48abe0807b35ecf451829e66
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.AE50vc (%install)


@cmsbuild
Copy link
Contributor

Pull request #8236 was updated.

@aandvalenzuela
Copy link
Contributor

please test

  • @arooshap feel free to start the testing also when you think the PR is ready :)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84c602/29707/summary.html
COMMIT: a1be711
CMSSW: CMSSW_12_6_X_2022-12-19-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8236/29707/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3458651
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3458626
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aandvalenzuela
Copy link
Contributor

Tests are passing now, do you agree to merge @arooshap, or do we expect more changes in this PR?

@arooshap
Copy link
Author

Hi @aandvalenzuela, yes please merge this PR.

Thank you :)

@arooshap
Copy link
Author

These changes incorporate a new tool murre under cmsmon.

@aandvalenzuela aandvalenzuela merged commit 48f8830 into cms-sw:IB/CMSSW_12_6_X/master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants