Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warnings related to HIP/ROCm in Alpaka #8303

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 9, 2023

Fix compilation warnings related to HIP/ROCm in Alpaka.
Use -isystem instead of -I to silence warnings in HIP/ROCm headers.

Other changes:

  • add support for MI200/MI210/MI250 CDNA2 GPUs;
  • include rocrand/hiprand headers from the main include directory (since ROCm 5.2.0).

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 9, 2023

This should fix most of the compilation warnings related to HIP/ROCm (actually, hiprand) in Alpaka.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_13_0_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor

please test

@iarspider
Copy link
Contributor

(IIUC, you need to make a separate comment to start the tests)

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 9, 2023

please abort

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 9, 2023

I'll have a follow up soon

@fwyzard fwyzard force-pushed the origin/IB/CMSSW_13_0_X/master_Alpaka_fix_ROCm_compilation_warnings branch from a4f6796 to 64aa710 Compare February 9, 2023 14:49
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 9, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

Pull request #8303 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd2c3e/30546/summary.html
COMMIT: 64aa710
CMSSW: CMSSW_13_0_X_2023-02-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8303/30546/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@fwyzard fwyzard force-pushed the origin/IB/CMSSW_13_0_X/master_Alpaka_fix_ROCm_compilation_warnings branch from 64aa710 to aa2c242 Compare February 9, 2023 15:15
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 9, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

Pull request #8303 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd2c3e/30547/summary.html
COMMIT: aa2c242
CMSSW: CMSSW_13_0_X_2023-02-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8303/30547/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555852
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555822
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 9, 2023

@smuzaffar @perrotta @rappoccio can we have this in pre4 ?
thanks !

@smuzaffar smuzaffar merged commit 475ad6c into cms-sw:IB/CMSSW_13_0_X/master Feb 9, 2023
@fwyzard fwyzard deleted the origin/IB/CMSSW_13_0_X/master_Alpaka_fix_ROCm_compilation_warnings branch March 3, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants