Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Triton client to version 2.25 #8324

Merged
merged 7 commits into from Mar 2, 2023

Conversation

kpedro88
Copy link
Contributor

This PR updates the Triton client to a newer version. Important changes:

  • Introduction of multi-request inference interfaces
  • Includes numerous PRs (from me) repositories to improve the build options, eliminating almost all of the manual patches we previously needed to apply in order to build only the necessary components in CMSSW.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_13_0_X/master to IB/CMSSW_13_1_X/master February 18, 2023 09:01
@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#40814

restart the tests after correcting the base branch ( 13.1.X )

common_tag_2_11_0=249232758855cc764c78a12964c2a5c09c388d87
mkdir repo-common && pushd repo-common && curl -k -L https://github.com/%{github_user}/common/archive/${common_tag_2_11_0}.tar.gz | tar -xz --strip=1 && popd
common_tag=d5c561841e9bd0818c40e5153bdb88e98725ee79
mkdir repo-common && pushd repo-common && curl -k -L https://github.com/%{github_user}/common/archive/${common_tag}.tar.gz | tar -xz --strip=1 && popd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpedro88 , I never noticed that we are downloading the sources here. Why not just make this an extra source

%define common_tag d5c561841e9bd0818c40e5153bdb88e98725ee79
Source1: https://github.com/%{github_user}/common/archive/%{common_tag}.tar.gz

this way it will be cached in cmsrep for future use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the suggestion, implemented

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30728/summary.html
COMMIT: 388cdc3
CMSSW: CMSSW_13_0_X_2023-02-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8324/30728/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonClient.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonException.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonMemResource.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonService.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/triton_utils.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonData.cc:7:10: fatal error: model_config.h: No such file or directory
    7 | #include "model_config.h"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonData.cc:7:10: fatal error: model_config.h: No such file or directory
    7 | #include "model_config.h"


@cmsbuild
Copy link
Contributor

Pull request #8324 was updated.

@aandvalenzuela
Copy link
Contributor

please test with cms-sw/cmssw#40814

@kpedro88
Copy link
Contributor Author

kpedro88 commented Feb 20, 2023

@smuzaffar I thought this would get tests-approved automatically when cms-sw/cmssw#40814 passed, since they are tested together. Do we need to specify the whole slew of related PRs everywhere now?

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 20, 2023

@smuzaffar I thought this would get tests-approved automatically when #40814 passed, since they are tested together. Do we need to specify the whole slew of related PRs everywhere now?

yes @kpedro88 since couple of years now :-) every PR should be tested individually to get the test-approved label.

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30761/summary.html
COMMIT: ace7b56
CMSSW: CMSSW_13_1_X_2023-02-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8324/30761/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30761/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30761/git-merge-result

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 28 lines to the logs
  • Reco comparison results: 6789 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3631295
  • DQMHistoTests: Total failures: 11600
  • DQMHistoTests: Total nulls: 67
  • DQMHistoTests: Total successes: 3619606
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -641.2850000000002 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -17.997 KiB JetMET/MET
  • DQMHistoSizes: changed ( 1000.0,... ): -1.050 KiB Egamma/Electrons
  • DQMHistoSizes: changed ( 10024.0,... ): -30.041 KiB JetMET/MET
  • DQMHistoSizes: changed ( 136.7611,... ): -12.044 KiB JetMET/MET
  • Checked 219 log files, 169 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 2 / 48 workflows

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30783/summary.html
COMMIT: ace7b56
CMSSW: CMSSW_13_1_X_2023-02-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8324/30783/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30783/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30783/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 17 lines from the logs
  • Reco comparison results: 32 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3631295
  • DQMHistoTests: Total failures: 42
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3631231
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 219 log files, 169 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@gartung
Copy link
Member

gartung commented Mar 1, 2023

@kpedro88 does this version of triton require a version of grpc newer than 1.35.00?

@kpedro88
Copy link
Contributor Author

kpedro88 commented Mar 1, 2023

I have not found any need to update the gRPC version.

@gartung
Copy link
Member

gartung commented Mar 1, 2023

OK. Thanks. I am updating the Fermilab Triton client version and they are trying to build gRPC 1.51.3.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Mar 1, 2023

The CMS build is very precise about using existing dependencies. The FNAL/ups version may just be picking up defaults from CMake.

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2023

merge

@cmsbuild cmsbuild merged commit da8f168 into cms-sw:IB/CMSSW_13_1_X/master Mar 2, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants