Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildRules] Changes for running unit tests from separate test dirs #8361

Merged
merged 1 commit into from Mar 6, 2023

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Mar 6, 2023

  • properly cleanup up top level unit test directory
  • add test directories of release/full release in path
  • Run test scripts using full path e.g. for <test name="FOO" command="bar.sh"/> test will be run as $CMSSW_BASE/src/Package/Name/test/bar.sh

These changes will allow to run unit tests from their separate test paths. This will avoid the issue if two or more tests writing in to same file in $CMSSW_BASE

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Mar 6, 2023

test parameters:

  • full_cmssw = true
  • skip_tests = static

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b5c55/31087/summary.html
COMMIT: 6b59221
CMSSW: CMSSW_13_1_X_2023-03-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8361/31087/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b5c55/31087/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b5c55/31087/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 182 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529727
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529698
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals

lets get this in, we still need to fix many unit tests so that they use full paths instead of src/Package

@smuzaffar smuzaffar merged commit a9983fc into IB/CMSSW_13_1_X/master Mar 6, 2023
10 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@iarspider iarspider deleted the smuzaffar-patch-5 branch March 13, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants