Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UCX to version 1.14.0 #8383

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 14, 2023

See https://github.com/openucx/ucx/releases/tag/v1.14.0 for the (long) release notes.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 14, 2023

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_13_1_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821708/31273/summary.html
COMMIT: d3bcafb
CMSSW: CMSSW_13_1_X_2023-03-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8383/31273/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821708/31273/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821708/31273/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test CalibCalorimetryEcalLaserSortingRunStreamer had ERRORS
---> test DQMServicesStreamerIORunStreamer had ERRORS

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 422 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550722
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 15, 2023

I hardly believe these errors

===== Test "CalibCalorimetryEcalLaserSortingRunStreamer" ====
LOCAL_TEST_DIR = /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-14-1100/src/CalibCalorimetry/EcalLaserSorting/test
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-14-1100/src/CalibCalorimetry/EcalLaserSorting/test/RunStreamer.sh: line 13: out: Is a directory
Failure cmsRun streamOut_cfg.py: status 1

---> test CalibCalorimetryEcalLaserSortingRunStreamer had ERRORS
TestTime:0
^^^^ End Test CalibCalorimetryEcalLaserSortingRunStreamer ^^^^

and

===== Test "DQMServicesStreamerIORunStreamer" ====
LOCAL_TEST_DIR = /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-14-1100/src/DQMServices/StreamerIO/test
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-14-1100/src/DQMServices/StreamerIO/test/RunStreamer.sh: line 15: out: Is a directory
Failure cmsRun streamOut_cfg.py: status 1

---> test DQMServicesStreamerIORunStreamer had ERRORS
TestTime:0
^^^^ End Test DQMServicesStreamerIORunStreamer ^^^^

are related to this PR.

@smuzaffar
Copy link
Contributor

+externals
unit tests failure are not releated to this PR ( see cms-sw/cmssw#41055 )

@smuzaffar smuzaffar merged commit 7995fbf into cms-sw:IB/CMSSW_13_1_X/master Mar 15, 2023
8 of 9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants