Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fasthadd file permissions #978

Merged
3 commits merged into from Oct 1, 2014

Conversation

diguida
Copy link

@diguida diguida commented Sep 1, 2014

The new fastHadd external deals correctly with file permissions, by setting them to 0664: this allows for testing/debugging purposes (files are accessible by all users), and for correctly handling files in DAQ2 (while in the same step, files are handled by the same user, when moved in the data flow chain, files should be handled by users in the same group).

@diguida
Copy link
Author

diguida commented Sep 1, 2014

@danduggan @deguio as discussed today and reported in Asana.

%define tag 743bde9939bbc4f34c2b4fd022cfb980314f912a
Source0: https://raw.githubusercontent.com/cms-sw/cmssw/%tag/DQMServices/Components/bin/fastHadd.cc
Source1: https://raw.githubusercontent.com/cms-sw/cmssw/%tag/DQMServices/Core/src/ROOTFilePB.proto
%define commit e193ee35083c2c1583e186130891087d6a4c7ac1 #commit mapped to CMSSW_7_1_6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you actually try this out? # is not a commend character for rpm keywords (like %define). You might want to move the comment above the define.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktf
I checked it with rpmlint, it was ok: mmhh :-(
Fixing it right now.
BTW, can you point me to the cmsbuild documentation? I found only sparse stuff in the Twiki.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all we have is in:

https://github.com/cms-sw/pkgtools/tree/V00-22-XX/docs

and it's admittedly sparse. Will try to improve it as I find time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no!
So dummy, I have bookmarked it... Shame on me :-(

@ghost ghost self-assigned this Oct 1, 2014
@ghost
Copy link

ghost commented Oct 1, 2014

+1
Tested compilation till cmssw-tool-conf.

ghost pushed a commit that referenced this pull request Oct 1, 2014
@ghost ghost merged commit f3d8c05 into cms-sw:IB/CMSSW_7_1_X/stable Oct 1, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants