Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C++ regex, not boost regex, in the framework where feasible. #10000

Merged
merged 1 commit into from Jul 15, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jul 1, 2015

std::regex is supported in gcc491, so we can use it instead of boost::regex in many cases.
boost::regex is used in the framework in six different places. This PR replaces the use of boost::regex with std::regex in those four places in the framework where the replacement is trivial and obvious.
In the other two cases, boost::regex use is left alone because boost functions are used that have no obvious equivalent in the C++ standard library.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2015

A new Pull Request was created by @wmtan for CMSSW_7_6_X.

Use C++ regex, not boost regex, in the framework where feasible.

It involves the following packages:

FWCore/Catalog
FWCore/Framework
FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2015

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jul 15, 2015
Use C++ regex, not boost regex, in the framework where feasible.
@cmsbuild cmsbuild merged commit 1b05465 into cms-sw:CMSSW_7_6_X Jul 15, 2015
@wmtan wmtan deleted the UseCplusplusRegex branch July 15, 2015 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants