Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of input sources that no longer exist. #10030

Merged
merged 1 commit into from Jul 9, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jul 3, 2015

I discovered that there are a large number of python config files that cannot possibly be run because the input sources used no longer exist. In particular, most of the generators were changed from sources to producers three years ago, and the old source classes were removed almost three years ago (Nov 2012). I am working on a generator feature that requires looking at a lot of config files that use generators, so it will make life easier if these obsolete config files that cannot possibly be used are removed from the release. The few changes to files not removed in this PR are trivial, namely removing or fixing obsolete comments or message wording.
This PR removes over 5500 source lines from CMSSW!

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2015

A new Pull Request was created by @wmtan for CMSSW_7_6_X.

Remove uses of input sources that no longer exist.

It involves the following packages:

CalibTracker/SiPixelErrorEstimation
CommonTools/CandAlgos
CommonTools/ParticleFlow
Configuration/Generator
Configuration/JetMET
Configuration/SVSuite
DQM/SiStripMonitorCluster
FastSimulation/CaloGeometryTools
FastSimulation/Configuration
FastSimulation/ForwardDetectors
FastSimulation/MaterialEffects
FastSimulation/MuonSimHitProducer
FastSimulation/Tracking
FastSimulation/Validation
GeneratorInterface/CosmicMuonGenerator
GeneratorInterface/GenExtensions
GeneratorInterface/GenFilters
GeneratorInterface/Herwig6Interface
GeneratorInterface/LHEInterface
Geometry/HcalCommonData
Geometry/TrackerCommonData
L1Trigger/RegionalCaloTrigger
PhysicsTools/Configuration
PhysicsTools/HepMCCandAlgos
PhysicsTools/JetMCAlgos
PhysicsTools/RooStatsCms
RecoParticleFlow/PFClusterTools
RecoRomanPot/RecoFP420
RecoTauTag/TauTagTools
SLHCUpgradeSimulations/Geometry
SimCalorimetry/EcalSimProducers
SimG4CMS/CherenkovAnalysis
SimG4CMS/ShowerLibraryProducer
SimG4CMS/Tracker
SimG4Core/CustomPhysics
SimG4Core/GFlash
SimG4Core/KillSecondaries
SimG4Core/PhysicsLists
SimRomanPot/SimFP420
SimTracker/TrackerFilters
SimTracker/TrackerMaterialAnalysis
Validation/EcalDigis
Validation/EcalRecHits
Validation/GlobalHits
Validation/MuonHits
Validation/RecoParticleFlow

@diguida, @lveldere, @ianna, @cerminar, @covarell, @bendavid, @civanch, @cmsbuild, @vciulli, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @deguio, @slava77, @vadler, @mmusich, @mulhearn, @ssekmen, @danduggan, @thuer, @monttj can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @argiro, @Martin-Grunewald, @threus, @venturia, @mmarionncern, @imarches, @makortel, @acaudron, @lgray, @jdolen, @ferencek, @cerati, @GiacomoSguazzoni, @rovere, @VinInn, @dgulhan, @mkirsano, @ahinzmann, @dkotlins, @matt-komm, @pvmulder, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Jul 3, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2015

The tests are being triggered in jenkins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment