Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EGM IDs for CMSSW 74X Redux #10035

Merged
merged 72 commits into from Jul 10, 2015
Merged

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 4, 2015

Contains a backport of #9659, without the ExpressionParser.

Also implements VID cutbased and MVA-based electron and photon IDs for PHYS 14 and Spring15

This is a recycling of: #9876 so that we can keep a lightweight EGM recipe in @ikrav's branch

@ikrav @cmkuo

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2015

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

EGM IDs for CMSSW 74X Redux

It involves the following packages:

CommonTools/CandAlgos
Configuration/StandardSequences
DataFormats/EgammaCandidates
DataFormats/FWLite
DataFormats/PatCandidates
PhysicsTools/PatAlgos
PhysicsTools/SelectorUtils
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification
RecoMuon/MuonIdentification

@smuzaffar, @Dr15Jones, @cvuosalo, @monttj, @cmsbuild, @franzoni, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @abbiendi, @rappoccio, @Martin-Grunewald, @mmarionncern, @imarches, @makortel, @acaudron, @jhgoh, @jdolen, @ferencek, @cerati, @trocino, @rociovilar, @Sam-Harper, @wmtan, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @nhanvtran, @schoef, @dgulhan, @battibass, @wddgit, @ahinzmann, @gpetruc, @mariadalfonso, @pvmulder, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2015

Pull request #10035 was updated. @smuzaffar, @Dr15Jones, @cvuosalo, @monttj, @cmsbuild, @franzoni, @slava77, @vadler, @davidlange6 can you please check and sign again.

2 similar comments
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2015

Pull request #10035 was updated. @smuzaffar, @Dr15Jones, @cvuosalo, @monttj, @cmsbuild, @franzoni, @slava77, @vadler, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2015

Pull request #10035 was updated. @smuzaffar, @Dr15Jones, @cvuosalo, @monttj, @cmsbuild, @franzoni, @slava77, @vadler, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jul 6, 2015

this PR has merge conflicts as well

@monttj
Copy link
Contributor

monttj commented Jul 10, 2015

+1

@lgray
Copy link
Contributor Author

lgray commented Jul 10, 2015

@franzoni Could you please take a look here and +1 if you find things agreeable? Thanks!

@lgray
Copy link
Contributor Author

lgray commented Jul 10, 2015

@gpetruc Could you also please take a look and give your blessing? Thanks!

davidlange6 added a commit that referenced this pull request Jul 10, 2015
@davidlange6 davidlange6 merged commit 7fe6c72 into cms-sw:CMSSW_7_4_X Jul 10, 2015
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Jul 12, 2015
… getByLabel((label,instance,process),handle) was broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants