Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ExoticaDQM_cfi.py #10104

Merged
merged 1 commit into from Jul 31, 2015
Merged

Update ExoticaDQM_cfi.py #10104

merged 1 commit into from Jul 31, 2015

Conversation

aescalante
Copy link
Contributor

Modified list of valid HLT trigger path names due to a typo in one of the trigger names.

@aescalante
Update ExoticaDQM_cfi.py
01f747a 
Modified list of valid HLT trigger path names due to a typo in one of the trigger names.
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jul 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

A new Pull Request was created by @aescalante (Alberto Escalante del Valle) for CMSSW_7_4_X.

Update ExoticaDQM_cfi.py

It involves the following packages:

DQM/Physics

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 10, 2015

please submit to 75x and 76x as well.
wait to see the PR there before approving.
thanks,
F.

@aescalante
Copy link
Contributor Author

Hello,

Do I have to create a new PR in 75X and 76X or is possible to propagate this request to the other versions?.
thanks.
Alberto.

@deguio
Copy link
Contributor

deguio commented Jul 17, 2015

you have to create them manually.. :(
you can cherry-pick the commit on top of 75 and 76 branches.
ciao,
F.

@deguio
Copy link
Contributor

deguio commented Jul 17, 2015

@aescalante
I see in the selections the following:
"HLT_"

is this wanted?
F.

@aescalante
Copy link
Contributor Author

In principle I am interested only the list of triggers trigger names before the last one, HLT_ , but for the beginning of the run I don’t want to see empty histograms due to a problem with the trigger names so for the moment I prefer to leave it like this and remove HLT_ selection in the future.

Other point is that there is a new RelVal sample for displaced fermions and there is an intention to add dedicated histograms to the exotica module, but before that in other to get filled the current histograms in RelMon for that relval I prefer to leave temporary the "HLT_ " until the new histograms are added and a HLT name is decided for those events.

In conclusion I agree that in long term this is not desired, but for the moment I prefer to have it. Of course, if there is is a problem with it I can modify the commit and remove the HLT_ because the main purpose of this commit was a fix in the Ele trigger name.

I hope is clearer now.
Alberto.

@deguio
Copy link
Contributor

deguio commented Jul 20, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: 01f747a
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 20-Jul-2015 11:45:02 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 182124 lumi: 40 event: 1893722
   [1] Running path 'pathALCARECOTkAlMinBiasHI'
   [2] Calling event method for module AlignmentTrackSelectorModule/'ALCARECOTkAlMinBiasHI'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: hiGeneralTracks
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 20-Jul-2015 11:46:40 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 194533 lumi: 329 event: 461582793
   [1] Running path 'pathALCARECOSiStripCalMinBias'
   [2] Calling event method for module AlignmentTrackSelectorModule/'ALCARECOSiStripCalMinBias'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: generalTracks
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 20-Jul-2015 11:53:07 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23609118
   [1] Running path 'pathALCARECOTkAlZMuMu'
   [2] Calling event method for module MuonSelector/'ALCARECOTkAlZMuMuGoodMuons'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Muon
Looking for module label: muons
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3.log
----- Begin Fatal Exception 20-Jul-2015 11:54:56 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23609118
   [1] Running path 'pathHotlineSkimCaloMET'
   [2] Calling event method for module VertexSelector/'pvFilter'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: offlinePrimaryVertices
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 20-Jul-2015 12:19:22 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'validation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneSpecified(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10104/6360/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10104/6617/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jul 31, 2015
@cmsbuild
Merge pull request #10104 from aescalante/patch-3
56f03a6 
Update ExoticaDQM_cfi.py
@cmsbuild cmsbuild merged commit 56f03a6 into cms-sw:CMSSW_7_4_X Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aescalante @cmsbuild @deguio @perrotta @davidlange6