Apply event filter before data prefetching for OutputModules #10202
Conversation
The method isn't used and the present signature does not allow for consumes. If it becomes necessary to return this functionality, it should be done by adding a stand alone function which is passed an EDGetTokenT<TriggerResults>. The legacy OutputModule uses a modified version of this to support StreamerOutputModuleBase.
The previous API for getTriggerResults would allow one to retrieve the results without having to first declare consumes. The new interface requires an EDGetTokenT<TriggerResults>. The implementation of this function also avoids coupling with the event selector code. This allowed those interfaces to be removed from TriggerResultsBasedEventSelector.
In order to allow event selection checking to run in parallel, we needed a TriggerResultsBasedEventSelector per stream.
Changes to the implementation of the OutputModule now require a properly initialized StreamID when calling the Event method.
…e prefetching data There is no reason to prefetch data and subsequently causing either delayed read or unscheduled execution if the TriggerResults being watched designate that the event should not be stored.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X. Apply event filter before data prefetching for OutputModules It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
Apply event filter before data prefetching for OutputModules
There is no reason to prefetch data and subsequently causing either delayed read or unscheduled execution if the TriggerResults being watched designate that the event should not be stored.