Hcal DD Rec and Sim Constants Cleanup

[ianna]

• Pick up vectors directly from HcalParameters record

[ianna]

@bsunanda - Please, check this. I've removed a few locally cached vectors and replaced them with directly accessed from HcalParameters record. Thanks.

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_7_6_X.

Hcal DD Rec and Sim Constants Cleanup

It involves the following packages:

Geometry/HcalCommonData

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ianna]

@bsunanda - would it make sense to add the remaining vectors which are calculated at initialisation of this class to HcalParameters? The same for Sim part?

[bsunanda]

I dont know which could be persistent and which could be transient variables. This depends on the analysis if you could make some computation at the beginning and use them later on. At this stage I suggest please do not change the payload and whatever can be calculated may be there at initialization.

---

From: Ianna Osborne [notifications@github.com]
Sent: 15 July 2015 16:50
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] Hcal DD Rec and Sim Constants Cleanup (#10214)

In Geometry/HcalCommonData/interface/HcalDDDRecConstants.hhttps://github.com//pull/10214#discussion_r34686162:

std::vector ietaMap; // Map Sim level ieta to Rec level ieta

• std::vector iEtaMin, iEtaMax; // Minimum and maximum eta
• std::vector maxDepth; // Maximum depth in HB/HE/HF/HO
• int nEta; // Number of bins in eta for HB and HE
• std::vector phiGroup; // Eta Grouping
  std::vector phibin; // Phi step for all eta bins (HB, HE, HO)

@bsunandahttps://github.com/bsunanda - would it make sense to add the remaining vectors which are calculated at initialisation of this class to HcalParameters? The same for Sim part?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/10214/files#r34686162.

[ianna]

@cmsbuild please test

[ianna]

+1

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10214/6237/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[bsunanda]

Dear Yana

I am reverting back some of the changes and keeping most of the ones which are surely improvements. I shall commit the changes sometime today and please see that they get integrated quickly enough. I am running out of time for pre2. I want all geometry related stuff to go in by pre2. Best regards

Sunanda

---

From: Ianna Osborne [notifications@github.com]
Sent: 15 July 2015 17:16
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] Hcal DD Rec and Sim Constants Cleanup (#10214)

+1

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/10214#issuecomment-121648819.