Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1t rcttodigi #10220

Merged
merged 16 commits into from Jul 24, 2015
Merged

L1t rcttodigi #10220

merged 16 commits into from Jul 24, 2015

Conversation

mulhearn
Copy link
Contributor

This is a reboot of PR #9931. This is an initial commit for the RCT unpacker using the Stage-1 Upgrade Readout using Fed 1350.

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Jul 15, 2015
@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_7_6_X.

L1t rcttodigi

It involves the following packages:

EventFilter/RctRawToDigi

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor Author

@isobelojalvo, this is of interest to you.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@isobelojalvo
Copy link
Contributor

@mulhearn Thank you!!

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10220/6238/summary.html

@mulhearn
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6
davidlange6 reviewed Jul 21, 2015
View reviewed changes
EventFilter/RctRawToDigi/plugins/RctRawToDigi.cc
verbose_(iConfig.getUntrackedParameter<bool>("verbose",false))
{
LogDebug("RCT") << "RctRawToDigi will unpack FED Id " << fedId_;
std::cout<< "RctRawToDigi will unpack FED Id " << fedId_<<std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mulhearn - could you remove this cout. thanks

davidlange6 added a commit that referenced this pull request Jul 24, 2015
@davidlange6
Merge pull request #10220 from cms-l1t-offline/l1t-rcttodigi
d9e3ab7 
L1t rcttodigi
@davidlange6 davidlange6 merged commit d9e3ab7 into cms-sw:CMSSW_7_6_X Jul 24, 2015
@nsmith- nsmith- mentioned this pull request Jul 27, 2015
Closed
@nsmith- nsmith- deleted the l1t-rcttodigi branch March 17, 2016 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mulhearn @cmsbuild @isobelojalvo @davidlange6