New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vestigial (and huge) GBRForest when running with PFEGAlgo (75X) #10317
Conversation
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X. Remove vestigial (and huge) GBRForest when running with PFEGAlgo (75X) It involves the following packages: RecoParticleFlow/PFProducer @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@slava77 I think the cmsbuild job died here. Probably need to start a new one. |
@cmsbuild, please test
|
Guess the poor robot died :( |
beep boop? |
b -> p |
I restarted the build. |
... looks like it's running the matrix now |
yep, I'm watching it too :-) |
I can post igprof reports here if you think it would help speed things along. |
Oh, right there's already an igprof report in the 76X PR. :-) |
+1 Removing unneeded GBRForest when running with PFEGAlgo. There should be no change in monitored quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-07-24-1100 show no significant differences, as expected. Memory use reduction was verified in the 74X version of this PR, #10319, which has already been approved by RECO. The 76X version of this PR, #10315, has also been approved by RECO. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Remove vestigial (and huge) GBRForest when running with PFEGAlgo (75X)
Backport of #10315