Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestigial (and huge) GBRForest when running with PFEGAlgo (75X) #10317

Merged
merged 1 commit into from Jul 28, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 23, 2015

Backport of #10315

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Remove vestigial (and huge) GBRForest when running with PFEGAlgo (75X)

It involves the following packages:

RecoParticleFlow/PFProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 23, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@lgray
Copy link
Contributor Author

lgray commented Jul 24, 2015

@slava77 I think the cmsbuild job died here. Probably need to start a new one.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

On Jul 24, 2015, at 8:15 AM, Lindsey Gray notifications@github.com wrote:

@slava77 I think the cmsbuild job died here. Probably need to start a new one.


Reply to this email directly or view it on GitHub.

@lgray
Copy link
Contributor Author

lgray commented Jul 24, 2015

Guess the poor robot died :(

@lgray
Copy link
Contributor Author

lgray commented Jul 24, 2015

beep boop?

@slava77
Copy link
Contributor

slava77 commented Jul 24, 2015

b -> p

@slava77
Copy link
Contributor

slava77 commented Jul 24, 2015

I restarted the build.
Hopefully it goes better this time.
Last time it got stuck on unit tests.

@slava77
Copy link
Contributor

slava77 commented Jul 24, 2015

... looks like it's running the matrix now

@lgray
Copy link
Contributor Author

lgray commented Jul 24, 2015

yep, I'm watching it too :-)

@lgray
Copy link
Contributor Author

lgray commented Jul 24, 2015

I can post igprof reports here if you think it would help speed things along.

@lgray
Copy link
Contributor Author

lgray commented Jul 24, 2015

Oh, right there's already an igprof report in the 76X PR. :-)

@cvuosalo
Copy link
Contributor

+1

For #10317 3a675d0

Removing unneeded GBRForest when running with PFEGAlgo. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-07-24-1100 show no significant differences, as expected. Memory use reduction was verified in the 74X version of this PR, #10319, which has already been approved by RECO. The 76X version of this PR, #10315, has also been approved by RECO.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants