Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fix to handle the error in the PVsorting #10344

Merged
merged 2 commits into from Jul 28, 2015

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Jul 24, 2015

This implements p4 scaling as a way to subtract the pt uncertainty in the PV sorting. Using the scaling also MET variable is protected against high pt / high error tracks.

This should also fix the Zmumu issue reported by @battibass

@slava77

this same branch can be used for 76X PR

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_7_5_X.

Better fix to handle the error in the PVsorting

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @jhgoh, @ahinzmann this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 24, 2015

@cmsbuild please test

Andrea, please submit a PR for 76X as well (just the same topic branch)

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jul 27, 2015

+1

for #10344 5ba3ce3

  • changes in the code are as discussed privately
  • relying primarily on results of tests done on many samples by @arizzi (~1% more vertices are expected to be selected in ZMM events ==> this should lead to ~2% increase in tight muon ID plots, expected to recover the loss introduced in pre6)
  • jenkins tests pass and show minor diffs in DQM plots
    • in MinBias2012A (1003.0) in a few vertex plots (the ones that select PV0 separately from others)
    • in TTbar with PU (50202)
  • somewhat higher statistics tests were run in CMSSW_7_5_0 /test are sign572/, including 200 events of Z->mumu with PU=35 (25206)
    • Zmumu has 3 more vertices matched to Gen becoming the PV0 (in agreement with Andrea's tests)
      wf25206_mu_tgt_vs_p
    • other test samples show no significant differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants