Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to GBRForest/Tree for converting TMVA classifiers (74X) #10370

Merged
merged 1 commit into from Jul 30, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 25, 2015

Backport of #10275

@bendavid

…nsistent behaviour of TMVA decision tree evaluation in different root versions
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

Enhancements to GBRForest/Tree for converting TMVA classifiers (74X)

It involves the following packages:

CondFormats/EgammaObjects

@ggovi, @cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Jul 25, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@diguida
Copy link
Contributor

diguida commented Jul 28, 2015

@lgray sorry for late signing, and thanks for the reminder.
@davidlange6 what is the proposed strategy here? I think that CMSSW_7_6_0_pre2 RelVal should confirm that no changes are seen. In this case, you can merge, but this will trigger a full build (interface changes).
Unfortunately I missed this at the ORP meeting: do you want me to add it to the TWiki for reference?

@slava77
Copy link
Contributor

slava77 commented Jul 30, 2015

@davidlange6 please check
this is blocking further backports now (10475)

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants