Backport of #10194 :Add shower-shape cut capability to electron seed producer

[harmonicoscillator]

This is a backport of PR #10194 to 7_5_X, and it will add shower-shape cut capability to the electron seed producer.

This supersedes PRs #10349 and #10331 which @doanhien was handling, but she is at a conference now and I will handle the PR. You can close those two PRs.

This PR makes the new cut default to OFF, so no changes are expected to occur. A follow-up PR which enables this cut along with others for Heavy-Ion workflows will follow later this week.

This PR passes matrices 5.1 and 140.53, and I can include the log output if requested.

[harmonicoscillator]

Copied from #10349:

Adding variable of sigma_ieta_ieta at seeding level for electron in HI reconstruction. The link to describe sigma_ieta_ieta cut is powerful to kill fake electron (which screw up the jet resolution in jet analysis) can be found here: https://twiki.cern.ch/twiki/pub/CMS/PhotonAnalyses2015/20150616.pdf. This variable was added and got PR successfully for 7_6_X. However, we would like to make a back port for 7_5_X since we will use 7_5_X for data taking in heavy ion
the number of the PR in 76X: #10194

[cmsbuild]

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_5_X.

Backport of #10194 :Add shower-shape cut capability to electron seed producer

It involves the following packages:

RecoEgamma/EgammaElectronProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 1e0271c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10405/5028/summary.html

[cvuosalo]

+1

For #10405 1e0271c

Added a sigma_ieta_ieta variable at electron seed level for use with HI workflows. The cut is disabled by default, so this PR should not change monitored quantities. A later PR may enable this cut after testing has established the desired cut value. This PR is a backport of #10194, which has already been merged into 76X.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-07-24-1100 show no significant differences, as expected.

[slava77]

+1
looks like the bot was asleep overnight
if this doesn't get through, @smuzaffar or @Degano please take a look

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[smuzaffar]

@slava77 , cms bot is running fine. The problem here is that @cvuosalo +1 was not on the first line (there is an empty line before it).

[davidlange6]

+1