Implement a well-behaved stack trace printer (75x backport) #10422
Conversation
This implements a stack trace printer which is safe to call from a signal handler (ROOT's stack trace printer is not async-signal safe; see 'man 7 signal' for more information about async-signal safety). Further, on Linux, this utilizes the clone library call directly; clone has the advantage of avoiding the pthread_atfork handlers. We have observed that jemalloc currently registers AS-unsafe atfork handlers, which would cause a deadlock if we use fork(). (cherry picked from commit cff10d3)
This switches from the system pstack script to using gdb directly. Ideally, this will be more usable on non-Linux platforms. NOTE that this will pull the gdb from the environment (i.e., probably CMSSW's gdb instead of the system one). CMSSW's gdb can parse the debug symbols we ship, meaning that the backtrace will include niceties like filenames, line numbers, and decode arguments. The downside of this is that CMSSW's gdb requires 10 minutes and about 1GB RAM to generate the traceback. (cherry picked from commit b6d0bae)
(cherry picked from commit 24c51a4)
|
A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_5_X. Implement a well-behaved stack trace printer (75x backport) It involves the following packages: FWCore/Services @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
comparison-pending
and removed
comparison-pending
core-approved
fully-signed
orp-pending
tests-pending
labels
|
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
…backport Implement a well-behaved stack trace printer (75x backport)
Backport of #10084 to 75x.