Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent too many chunks from being added per function call (forward port to 7_5_X). #10423

Merged

Conversation

bbockelm
Copy link
Contributor

We have a limit of 1,024 chunks per IO vector and stop adding new
chunks once we hit 1,000. However, the consumeChunk* calls previously
were able to add an unlimited number of new chunks - meaning that we
could go past the limit in a single loop iteration.

Forward port of #10021

(cherry picked from commit 53e2f4d)

We have a limit of 1,024 chunks per IO vector and stop adding new
chunks once we hit 1,000.  However, the consumeChunk* calls previously
were able to add an unlimited number of new chunks - meaning that we
could go past the limit in a single loop iteration.

(cherry picked from commit 53e2f4d)
@bbockelm bbockelm changed the title Prevent too many chunks from being added per function call. Prevent too many chunks from being added per function call (forward port to 7_5_X). Jul 28, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jul 28, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_5_X.

Prevent too many chunks from being added per function call (forward port to 7_5_X).

It involves the following packages:

Utilities/XrdAdaptor

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10423/6776/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jul 29, 2015
…ardport

Prevent too many chunks from being added per function call (forward port to 7_5_X).
@cmsbuild cmsbuild merged commit 056aeec into cms-sw:CMSSW_7_5_X Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants