Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MET uncertainty tool backporting in 74X (ONLY if miniAOD reprocessing is done with 74X) #10443

Merged
merged 36 commits into from Sep 8, 2015
Merged

MET uncertainty tool backporting in 74X (ONLY if miniAOD reprocessing is done with 74X) #10443

merged 36 commits into from Sep 8, 2015

Conversation

mmarionncern
Copy link

This PR is in preparation of the 50ns miniAOD reprocessing and has to be merged ONLY if that reprocessing is performed with 74X.

The PR contains the content of #9117 and #10240

matthieu and others added 22 commits July 23, 2015 15:17
Fixing the few conflicts appeared during the development
98ce00a 
update reco MET correction producers

Conflicts:
	JetMETCorrections/Type1MET/interface/PFJetMETcorrInputProducerT.h
	JetMETCorrections/Type1MET/plugins/AddCorrectionsToCaloMET.cc
	JetMETCorrections/Type1MET/plugins/AddCorrectionsToPFMET.cc

Conflicts:
	JetMETCorrections/Type1MET/plugins/AddCorrectionsToCaloMET.cc
	JetMETCorrections/Type1MET/plugins/AddCorrectionsToPFMET.cc
@schoef
First commit of multiplicity based corrections
ff288b7
@schoef
modification of MET std correction modules and XY correction module
c791563
modification of MET std correction modules and XY correction module, …
a4ee308 
…roung 2
modification of MET std correction modules and XY correction module, …
dee9a41 
…round 3
finish first migration
a113162
new MET uncertainty tool, part 2
52e5abc
change of pat::MET format
966ff1c
first working version, cleaning not yet done
baa83b6
last modifications, check for 74X compatibility, cleaning
55c6e86
cleaning
d99b026
@schoef
fixed JetMETCorrections/Type1MET/test/testMultShiftMETcorrInputProduc…
78fb71b 
…er.py
fix pfmet correction test, removed unphysical T0T2 MET flavors
e329f57
fix corrMET_pfMet_cfg test
72ed072
added warning for negative JEC correction potentially noticed in the …
03d6097 
…Type1MET computation
update MET correction tool: PhotonES, automatic function, preparatino…
745d210 
… for MVA MET
cleaning + jet cleansing set to electrons/muons only
368eadd
move to CHS T1 at the RECO level
2f6bbd4
update the MET XY correction and met reprocessing example
b10f787
set the automatic switch of JECs for MC and data, tags can still be s…
a7710b5 
…pecified by the user
add GenMETExtractor for MET reprocessing in miniAOD
76170c1
fix data switch and CHS handling
5f831ae
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jul 29, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_7_4_X.

MET uncertainty tool backporting in 74X (ONLY if miniAOD reprocessing is done with 74X)

It involves the following packages:

DataFormats/PatCandidates
JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @TaiSakuma, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

-1
Tested at: f9a4e24
When I ran the RelVals I found an error in the following worklfows:
4.53 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10443/7778/summary.html

@schoef
Copy link
Contributor

schoef commented Sep 3, 2015

@slava77
Are there news on this? Is this really a DAS problem or are there action items for us?

@slava77
Copy link
Contributor

slava77 commented Sep 3, 2015

@cmsbuild please test
lets try again

@schoef please note that I'm not the one to sign off on this.
My earlier comments were just to aid with the review

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

+1
Tested at: f9a4e24
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10443/7873/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10443/7873/summary.html

@davidlange6
Copy link
Contributor

@montjj, @deguio - any comments on this PR? we should have this in place to finalize the miniAOD release for 74x.

@monttj
Copy link
Contributor

monttj commented Sep 4, 2015

+1
I don't have any comments on this PR.

@mmarionncern
Copy link
Author

@deguio @davidlange6 , ping?

davidlange6 added a commit that referenced this pull request Sep 8, 2015
@davidlange6
Merge pull request #10443 from cms-met/METCorUnc_75XbackportFor74X
6bf8c6e 
MET uncertainty tool backporting in 74X (ONLY if miniAOD reprocessing is done with 74X)
@davidlange6 davidlange6 merged commit 6bf8c6e into cms-sw:CMSSW_7_4_X Sep 8, 2015
@blinkseb
Copy link
Contributor

Hi guys,

This PR removed pat::MET::uncorrectedPt(), pat::MET::uncorrectedPhi(), pat::MET::uncorrectedSumEt() code implementation but not definition in header. Please fix it, in 7.4.12 I now have a bunch of linker undefined references.

By the way, is this removal intentional? What should I use instead?

@mmarionncern
Copy link
Author

@blinkseb The removal is intentional those functions were linked to the old format, you can use the unCor functions instead (pat::MET::unCorPt() for example).

@blinkseb
Copy link
Contributor

Ok thanks, but please remove the declaration from the header file otherwise these functions will still be shown in the doxygen.

@mmarionncern mmarionncern deleted the METCorUnc_75XbackportFor74X branch November 14, 2016 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available dqm-pending operations-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet