Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for GEN infos in 75X #10480

Merged
merged 1 commit into from Aug 12, 2015
Merged

Conversation

emiglior
Copy link
Contributor

This is essentially the forward porting of PR #10477 (but is starts from PR #10072 which was already included in CMSSW_75X).
The current PR includes the first round of modifications to fill properly the GEN level infos from pythia8 and NLO Monte Carlo generators.
RECO is not affected.
@maralxplus, @mabarrio This can be of interest for you as well as it affects the format of the trees created by MuScleFit as it includes an event weight useful for NLO MC,

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @emiglior (Ernesto Migliore) for CMSSW_7_5_X.

Update for GEN infos in 75X

It involves the following packages:

MuonAnalysis/MomentumScaleCalibration

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@bellan, @mmusich, @frmeier, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Aug 3, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

@monttj
Copy link
Contributor

monttj commented Aug 6, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 12, 2015
@cmsbuild cmsbuild merged commit d150b6e into cms-sw:CMSSW_7_5_X Aug 12, 2015
@emiglior emiglior deleted the changes_pythia8_75X branch May 31, 2016 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants