Gem segment 76 #10485
Merged
Gem segment 76 #10485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRToFixMess_ME0Segment_PR_v1
| for (auto rh=rechits.begin(); rh!=rechits.end(); ++rh){ | ||
| timeUncrt += pow((*rh)->tof()-averageTime,2); | ||
| } | ||
| if(rechits.size() != 0) timeUncrt=timeUncrt/(rechits.size()); |
There was a problem hiding this comment.
this will be exactly 0 for rechits = 1; not sure it matters, but still worth to note
There was a problem hiding this comment.
noted, but does not matter, because the segment is only made when there are 2 or more hits.
|
@pietverwilligen please let me know your plans about #10485 (comment) |
|
please test. |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1
|
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for making segments in ME0. This is one of the last PRs for porting Muon Upgrade code from SLHC to 76X. Last PR to be expected is a PR containing code to reconstruct ME0Muons starting from these ME0 segments.
@cvuosalo I have tried as much as possible to check for comments you made for the GEMCSC Segment PR #9083 and to comments made earlier to ME0Segment code in PR #8912.
@slava77 and @cvuosalo please let me know your comments.
greets
Piet