Use Hcal Trigger Tower Geometry from Event Setup

[ianna]

• Use Hcal trigger tower geometry from Event setup

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_7_6_X.

Use Hcal Trigger Tower Geometry from Event Setup

It involves the following packages:

CondFormats/DataRecord
CondTools/L1Trigger
L1TriggerConfig/L1ScalesProducers

@diguida, @cerminar, @cmsbuild, @ggovi, @mmusich, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ianna]

@mulhearn - please, review this proposal.

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[mulhearn]

So I guess the HCalScales producer relies on the L1CaloGeometry for O2O. In the past you just setup the L1CaloGeometry via config file parameters, and used that when producing L1CaloGeometry, but now you want to take it from the database. This means the HCalScales will depend on L1CaloGeometry. Do I understand correctly?

[mulhearn]

I doubt standard relvals are enough of a test here, we will have to test that this still works in our O2O...

[cmsbuild]

+1
Tested at: 96cd060
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10494/7497/summary.html

[ianna]

@ggovi - ping

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

@cmsbuild, please test
(the old tests are gone)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9202/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: 6bb57e5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10494/9202/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10494/9202/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1