Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix geometry comparison #1050

Merged

Conversation

ghellwig
Copy link

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghellwig (Gregor Hellwig) for CMSSW_6_2_X.

Bugfix geometry comparison

It involves the following packages:

Alignment/OfflineValidation

@demattia, @smuzaffar, @nclopezo, @rcastello can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@davidlt you are the release manager for this.

@demattia
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlt can you please take care of it?

@fabiocos
Copy link
Contributor

+1

@ghellwig
Copy link
Author

Can I ask, what the status of this is?
I am a bit confused, since this is assigned to milestone CMSSW_6_2_3, but even CMSSW_6_2_3_patch1 is already released since two weeks.

@ghellwig
Copy link
Author

May I ask you, @davidlt , if you are going to build another 62X release?
Maybe this pull request should be assigned to another milestone, like CMSSW_6_2_3_patch2 ?

Cheers,
Gregor

@ghost ghost assigned davidlt Nov 15, 2013
@davidlt
Copy link
Contributor

davidlt commented Nov 15, 2013

It's being tested now.

@ghellwig
Copy link
Author

Ok, thank you!
I was just wondering because I could not select CMSSW_6_2_3 from the list of milestones anymore, but only from this pull request which is assigned to this milestone.

davidlt added a commit that referenced this pull request Nov 15, 2013
@davidlt davidlt merged commit 664051c into cms-sw:CMSSW_6_2_X Nov 15, 2013
@ghellwig ghellwig deleted the bugfix_geometry_comparison_62X branch December 2, 2013 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants