Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove l1menu customs plus l1bugfix 74 x #10506

Conversation

mulhearn
Copy link
Contributor

This is PR #10413 plus a bugfix to remove problems with postLS1 customizations always configuring for stage 1. Once it is shown to work, the bugfix will have to go into 75X and 76X as well.

@mulhearn
Copy link
Contributor Author

mulhearn commented Aug 1, 2015

+1

@mulhearn
Copy link
Contributor Author

mulhearn commented Aug 1, 2015

print it!

@davidlange6
Copy link
Contributor

@mulhearn - thanks - thats solves the problem

davidlange6 added a commit that referenced this pull request Aug 1, 2015
…plus-l1bugfix-74X

Remove l1menu customs plus l1bugfix 74 x
@davidlange6 davidlange6 merged commit edd1cb2 into cms-sw:CMSSW_7_4_X Aug 1, 2015
@fwyzard
Copy link
Contributor

fwyzard commented Aug 5, 2015

@mulhearn , you have removed the overriding of the L1 menu in the heavy ions workflow, but the corresponding L1 menu is not available in any global tag.

@Martin-Grunewald
Copy link
Contributor

@fwyzard
well, HIon relvals work, no?

@@ -31,6 +31,8 @@ def Base(process):
# process.GlobalTag.connect = 'frontier://FrontierProd/CMS_CONDITIONS'
# process.GlobalTag.pfnPrefix = cms.untracked.string('frontier://Frontie#rProd/')
#
process.GlobalTag.snapshotTime = cms.string("9999-12-31 23:59:59.000")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no hope to get a gt with the right snapshot time?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No: this is for the updated L1 menus versions - we can't wait for the GT PRs,
and some L1T menus will never make a GT (eg, the special LowPU L1T menus).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand it correctly that these customs never make it to relval
production workflows? Otherwise we can get conditions changing during
relval production.
On Aug 5, 2015 4:28 AM, "Martin Grunewald" notifications@github.com wrote:

In HLTrigger/Configuration/python/CustomConfigs.py
#10506 (comment):

@@ -31,6 +31,8 @@ def Base(process):

process.GlobalTag.connect = 'frontier://FrontierProd/CMS_CONDITIONS'

process.GlobalTag.pfnPrefix = cms.untracked.string('frontier://Frontie#rProd/')

  • process.GlobalTag.snapshotTime = cms.string("9999-12-31 23:59:59.000")

No: this is for the updated L1 menus versions - we can't wait for the GT
PRs,
and some L1T menus will never make a GT (eg, the special LowPU L1T menus).


Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/10506/files#r36283767.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not used in production workflows, as it would need to be explcitely called as customisation function.

@mulhearn mulhearn deleted the remove-l1menu-customs-plus-l1bugfix-74X branch January 25, 2016 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants