Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kCanRebin is not supported in ROOT6 #10544

Merged
merged 1 commit into from Aug 4, 2015
Merged

kCanRebin is not supported in ROOT6 #10544

merged 1 commit into from Aug 4, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Aug 4, 2015

For ROOT histograms, kCanRebin is not supported in ROOT6. This PR
replaces all remaining uses of kCanRebin with the ROOT6 equivalents.

See PR #10200

I noticed this one after updated ROOT 6.04 in DEVEL IBs. Changed based on #10200 and compile tested on CMSSW_7_6_DEVEL_X_2015-08-03-2300.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

kCanRebin is not supported in ROOT6
2d9373a 
For ROOT histograms, kCanRebin is not supported in ROOT6. This PR
replaces all remaining uses of kCanRebin with the ROOT6 equivalents.

See PR cms-sw#10200

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 4, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

kCanRebin is not supported in ROOT6

It involves the following packages:

DQMServices/Components

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlt
Copy link
Contributor Author

davidlt commented Aug 4, 2015

@wmtan @davidlange6 this is needed to bring back DEVEL IBs after I updated ROOT 6.04.XX.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

+1
Tested at: 2d9373a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10544/193176/summary.html

davidlange6 added a commit that referenced this pull request Aug 4, 2015
@davidlange6
Merge pull request #10544 from davidlt/root64-kCanRebin
535073c 
kCanRebin is not supported in ROOT6
@davidlange6 davidlange6 merged commit 535073c into cms-sw:CMSSW_7_6_X Aug 4, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10544/193176/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending dqm-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidlt @cmsbuild @davidlange6