Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T fixes for ConfDB parsing (74X) #10545

Merged
merged 4 commits into from Aug 4, 2015

Conversation

Martin-Grunewald
Copy link
Contributor

L1T fixes for ConfDB parsing (74X):
In fillDescriptions, all parameters must have a value, even if dummy.
The behaviour of a module must NOT depend on whether a parameter is present or not in the config -
ConfDB handles only a fixed set of parameters!
Once a fillDescriptions is made, the explicit py files in ../python should be removed to avoid ambiguities.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_4_X.

L1T fixes for ConfDB parsing (74X)

It involves the following packages:

EventFilter/L1TRawToDigi
L1Trigger/L1TCalorimeter

The following packages do not have a category, yet:

EventFilter/L1TRawToDigi

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants