Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DQM Validation plots for MSSM Hbb Trigger Paths. #10549

Merged
merged 4 commits into from Sep 1, 2015
Merged

add DQM Validation plots for MSSM Hbb Trigger Paths. #10549

merged 4 commits into from Sep 1, 2015

Conversation

heppye
Copy link
Contributor

@heppye heppye commented Aug 4, 2015

add DQM Validation plots for MSSM Hbb Trigger Paths.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

A new Pull Request was created by @heppye (Ye Chen) for CMSSW_7_5_X.

add DQM Validation plots for MSSM Hbb Trigger Paths.

It involves the following packages:

HLTriggerOffline/Higgs

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@heppye
Copy link
Contributor Author

heppye commented Aug 5, 2015

this PR have been checked by STEAM experts already. Information could be found at https://its.cern.ch/jira/browse/CMSHLT-470. Please process if possible.

@deguio
Copy link
Contributor

deguio commented Aug 6, 2015

please test

@deguio
Copy link
Contributor

deguio commented Aug 6, 2015

+1
provided it passes the tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10549/5301/summary.html

There are some workflows for which there are errors in the baseline:
4.53 step 2
4.22 step 2
140.53 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@deguio
Copy link
Contributor

deguio commented Aug 7, 2015

@cmsbuild new commits here

@deguio
Copy link
Contributor

deguio commented Aug 7, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@heppye
Copy link
Contributor Author

heppye commented Aug 13, 2015

@davidlange6 , could the PR be merged now?

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

Pull request #10549 was updated. can you please check and sign again.

cmsbuild added a commit that referenced this pull request Sep 1, 2015
add DQM Validation plots for MSSM Hbb Trigger Paths.
@cmsbuild cmsbuild merged commit 55ac7a3 into cms-sw:CMSSW_7_5_X Sep 1, 2015
@heppye heppye deleted the patch-5 branch April 3, 2016 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants