Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim pixel res histo update #10555

Merged
merged 4 commits into from Aug 7, 2015
Merged

Fastsim pixel res histo update #10555

merged 4 commits into from Aug 7, 2015

Conversation

lveldere
Copy link
Contributor

@lveldere lveldere commented Aug 4, 2015

edits #9803
takes into account that the new pixel resolution files are in cmsdist
cms-sw/cmsdist#1695

@lveldere
Copy link
Contributor Author

lveldere commented Aug 4, 2015

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 4, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

A new Pull Request was created by @lveldere for CMSSW_7_6_X.

Fastsim pixel res histo update

It involves the following packages:

FastSimulation/TrackingRecHitProducer

@cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@davidlange6
Copy link
Contributor

@lveldere - is this ready to be merged (I assume so, but you have not signed it)

@lveldere
Copy link
Contributor Author

lveldere commented Aug 7, 2015

+1

comparisons produced in private, and found to be good.

@lveldere
Copy link
Contributor Author

lveldere commented Aug 7, 2015

@davidlange6
thanks

davidlange6 added a commit that referenced this pull request Aug 7, 2015
@davidlange6 davidlange6 merged commit 3e2c9b7 into cms-sw:CMSSW_7_6_X Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants