Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced plugin for generator-level tt+X event categorisation #10564

Merged

Conversation

bartosik-hep
Copy link
Contributor

Allows to separate between different tt+jets subprocesss with a single integer number: tt+bb, tt+cc, tt+2b, tt+2c, tt+light jet, etc.
An improved version of the custom producer provided in the TWiki, based on the GenHFHadronMatcher tool.
Supports all decay channels of the ttbar system.
To be used by Top and ttH analyses.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

A new Pull Request was created by @bartosik-desy (Nazar Bartosik) for CMSSW_7_6_X.

Introduced plugin for generator-level tt+X event categorisation

It involves the following packages:

TopQuarkAnalysis/TopTools

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@kreczko this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Aug 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@kreczko
Copy link
Contributor

kreczko commented Aug 4, 2015

+1

1 similar comment
@monttj
Copy link
Contributor

monttj commented Aug 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

// ------------ method returns a vector of jet indices from the given map, sorted by N hadrons in descending order ------------
std::vector<int> GenTtbarCategorizer::nHadronsOrderedJetIndices(const std::map<int, int>& m_jetIndex)
{
std::vector<std::pair<int, int> > v_jetNhadIndexPair;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to add a v_jetNhadIndexPair.reserve(m_jetIndex.size()); here

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #10564 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Sep 24, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 4, 2015
…gorizer

Introduced plugin for generator-level tt+X event categorisation
@cmsbuild cmsbuild merged commit 97d5e37 into cms-sw:CMSSW_7_6_X Oct 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants