Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: make PFJetId-calculation configurable with maxEta parameter, set defa… #10571

Merged

Conversation

kirschen
Copy link
Contributor

@kirschen kirschen commented Aug 4, 2015

…ult to eta 5.2

76X PR: #10570

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

A new Pull Request was created by @kirschen for CMSSW_7_4_X.

Backport: make PFJetId-calculation configurable with maxEta parameter, set defa

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

-1
The code must reproduce the old behaviour; thus set maxEta to 1e99.

to be on the absolutely safe side in reproducing previous behavior
@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

Pull request #10571 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 11, 2015
…rable74X

Backport: make PFJetId-calculation configurable with maxEta parameter, set defa…
@cmsbuild cmsbuild merged commit f5994ab into cms-sw:CMSSW_7_4_X Aug 11, 2015
@kirschen kirschen deleted the MakeHLTPFJetIdProducerConfigurable74X branch August 11, 2015 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants