Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MET Filter update (port of #10604) #10608

Merged
merged 15 commits into from Aug 31, 2015
Merged

Conversation

schoef
Copy link
Contributor

@schoef schoef commented Aug 6, 2015

Please see #10604

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

A new Pull Request was created by @schoef for CMSSW_7_5_X.

MET Filter update for mAOD reprocessing (port of #10604)

It involves the following packages:

CalibMuon/DTCalibration
CommonTools/RecoAlgos
PhysicsTools/PatAlgos
RecoMET/METFilters

@diguida, @cvuosalo, @cerminar, @monttj, @cmsbuild, @slava77, @vadler, @mmusich can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @imarches, @makortel, @acaudron, @abbiendi, @mmarionncern, @jhgoh, @ahinzmann, @nhanvtran, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@schoef schoef changed the title MET Filter update for mAOD reprocessing (port of #10604) MET Filter update (port of #10604) Aug 6, 2015
@slava77
Copy link
Contributor

slava77 commented Aug 6, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10608/193930/summary.html

There are some workflows for which there are errors in the baseline:
4.53 step 2
4.22 step 2
140.53 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77
Copy link
Contributor

slava77 commented Aug 11, 2015

+1

for #10608 c93b975

  • code changes are as expected
  • same code as in 74X and in 76X version (74X was tested additionally with run2 prompt reco setup)
  • jenkins tests passed and comparisons with the baseline show no relevant differences
    • jenkins comparisons there show diffs in logErrors which are expected to change due to changes in the running modules

@slava77
Copy link
Contributor

slava77 commented Aug 17, 2015

@monttj, @mmusich @diguida
Please check, your signatures are needed
Thank you

@mmusich
Copy link
Contributor

mmusich commented Aug 18, 2015

+1
clean up of ALCARECODtCalibHI and ALCARECODtCalib configurations.
The 76X equivalent #10604 is already signed

@slava77
Copy link
Contributor

slava77 commented Aug 20, 2015

@monttj
please check if this PR is OK
Thanks

@monttj
Copy link
Contributor

monttj commented Aug 20, 2015

+1
same for AT

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 31, 2015
@cmsbuild cmsbuild merged commit f9e0f12 into cms-sw:CMSSW_7_5_X Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants