Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New track algorithm names for HI muon RegIt #10659

Merged
merged 12 commits into from Sep 1, 2015

Conversation

echapon
Copy link
Contributor

@echapon echapon commented Aug 10, 2015

75X equivalent of #10653

Conflicts:
	RecoHI/HiMuonAlgos/python/HiRegitMuonDetachedTripletStep_cff.py
	RecoHI/HiMuonAlgos/python/HiRegitMuonInitialStep_cff.py
	RecoHI/HiMuonAlgos/python/HiRegitMuonLowPtTripletStep_cff.py
	RecoHI/HiMuonAlgos/python/HiRegitMuonMixedTripletStep_cff.py
	RecoHI/HiMuonAlgos/python/HiRegitMuonPixelLessStep_cff.py
	RecoHI/HiMuonAlgos/python/HiRegitMuonPixelPairStep_cff.py
	RecoHI/HiMuonAlgos/python/HiRegitMuonTobTecStep_cff.py
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @echapon (Emilien Chapon) for CMSSW_7_5_X.

New track algorithm names for HI muon RegIt

It involves the following packages:

DataFormats/TrackReco
RecoHI/HiMuonAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @MiheeJo, @jazzitup, @VinInn, @richard-cms, @yenjie, @kurtejung, @gpetruc, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 9482f86
I found an error when building:

>> Checking EDM Class Version for src/DataFormats/VertexReco/src/classes_def.xml in libDataFormatsVertexRecoCapabilities.so
>> Building shared library tmp/slc6_amd64_gcc491/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/libDataFormatsHcalIsolatedTrack.so
Copying tmp/slc6_amd64_gcc491/src/DataFormats/VertexReco/test/testDataFormatsVertexReco/testDataFormatsVertexReco to productstore area:
>> Building shared library tmp/slc6_amd64_gcc491/src/DataFormats/V0Candidate/src/DataFormatsV0Candidate/libDataFormatsV0Candidate.so
Copying tmp/slc6_amd64_gcc491/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/libDataFormatsHcalIsolatedTrack.so to productstore area:
error: class 'reco::GsfTrack' has a different checksum for ClassVersion 15. Increment ClassVersion to 16 and assign it to checksum 2463004588
Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/GsfTrackReco/src/classes_def.xml.generated with updated ClassVersion
@@@@ ----> OK  EDM Class Version 
gmake: **\* [tmp/slc6_amd64_gcc491/src/DataFormats/GsfTrackReco/src/DataFormatsGsfTrackReco/libDataFormatsGsfTrackRecoCapabilities.so] Error 1
Copying tmp/slc6_amd64_gcc491/src/DataFormats/V0Candidate/src/DataFormatsV0Candidate/libDataFormatsV0Candidate.so to productstore area:
>> Leaving Package GeneratorInterface/HiGenCommon


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10659/7111/summary.html

@echapon
Copy link
Contributor Author

echapon commented Aug 11, 2015

Updating this PR too, the problem being the same as its 76X equivalent #10653

@cmsbuild
Copy link
Contributor

Pull request #10659 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Aug 11, 2015

@cmsbuild please test

@echapon I hope you have tested that the code compiles this time
(if you think you did it last time, please share the steps; you may be doing it wrong, e.g., cms-checkdeps is missing)

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

echapon added a commit to echapon/cmssw that referenced this pull request Aug 26, 2015
@cvuosalo
Copy link
Contributor

@cmsbuild please test
Comparisons stuck in Queued state

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #10659 f5021e4

Small adjustments for Heavy Ion regional iterative tracking. #10653 is the 76X version of this PR, and it has already been merged.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-08-27-2300 show a number of small differences, none significant. See #10653 for a discussion of the minor differences created by this PR and for information on processing time changes.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 1, 2015
New track algorithm names for HI muon RegIt
@cmsbuild cmsbuild merged commit 8d1a1a4 into cms-sw:CMSSW_7_5_X Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants