Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impact parameter significance histograms to tracking DQM (74X) #10660

Merged
merged 2 commits into from Aug 19, 2015

Conversation

makortel
Copy link
Contributor

Backport of #8410 and #9099:

Add following histograms for impact parameter significances

  • dxy and dz wrt. both primary vertex and beam spot
  • signed 2D and 3D impact parameters wrt. primary vertex as defined in IPTools

Add a new flag doSIPPlots to control if they're filled or not. By default it is set to False, and enabled when PCA histograms are.

Tested in 748patch1, expecting only the addition of the "SIP*" histograms.

@VinInn @rovere

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_4_X.

Add impact parameter significance histograms to tracking DQM (74X)

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorSource

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@VinInn
Copy link
Contributor

VinInn commented Aug 11, 2015

@deguio , @davidlange6 it would be very useful to have this in next prod (patch) release

@deguio
Copy link
Contributor

deguio commented Aug 12, 2015

ciao @makortel
don't you want to have this in 75 as well?
F.

@deguio
Copy link
Contributor

deguio commented Aug 12, 2015

please test

@makortel
Copy link
Contributor Author

@Degano The original PRs were in 75x :)

@makortel
Copy link
Contributor Author

Sorry, that should have been @deguio (being too quick with the tab)

@deguio
Copy link
Contributor

deguio commented Aug 12, 2015

ups, you are right. it was before the 76x times.
thanks,
F.

@deguio
Copy link
Contributor

deguio commented Aug 12, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 19, 2015
Add impact parameter significance histograms to tracking DQM (74X)
@cmsbuild cmsbuild merged commit c059c68 into cms-sw:CMSSW_7_4_X Aug 19, 2015
@makortel makortel deleted the dqmSip74x branch October 20, 2016 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants