Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all remaining RECO & MiniAOD modules that are executed to threaded FW (75X) #10671

Merged
merged 21 commits into from Sep 23, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Aug 10, 2015

Backport of #11140

@lgray
Copy link
Contributor Author

lgray commented Aug 10, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 10, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Convert all remaining MiniAOD modules to threaded FW (75X)

It involves the following packages:

CommonTools/ParticleFlow
CommonTools/RecoAlgos
CommonTools/RecoUtils
CommonTools/UtilAlgos
CommonTools/Utils
DataFormats/PatCandidates
JetMETCorrections/Type1MET
PhysicsTools/HepMCCandAlgos
PhysicsTools/JetCharge
PhysicsTools/JetMCAlgos
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
RecoEgamma/EgammaPhotonProducers
RecoJets/JetProducers

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @jdolen, @imarches, @makortel, @acaudron, @abbiendi, @mmarionncern, @jhgoh, @ahinzmann, @nhanvtran, @yslai, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lgray
Copy link
Contributor Author

lgray commented Aug 11, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #10671 was updated. @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please check and sign again.

@lgray
Copy link
Contributor Author

lgray commented Aug 11, 2015

@cmsbuild please test

@lgray
Copy link
Contributor Author

lgray commented Sep 16, 2015

@mulhearn Thanks for the prompt response in any case. :-)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #10671 13095bd

This PR was already fully approved, but then a rebase was necessary. New Jenkins tests against baseline CMSSW_7_5_X_2015-09-15-2300 show no significant differences.

@lgray
Copy link
Contributor Author

lgray commented Sep 16, 2015

@monttj Please resign. Thanks!

@slava77
Copy link
Contributor

slava77 commented Sep 18, 2015

@monttj
please check this PR
Thank you.

@lgray
Copy link
Contributor Author

lgray commented Sep 21, 2015

@monttj please check and sign this PR. Thanks!

@lgray
Copy link
Contributor Author

lgray commented Sep 21, 2015

@davidlange6 This one too whenever you feel like it (it's in 74X/76X for a while now)

@monttj
Copy link
Contributor

monttj commented Sep 22, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@lgray
Copy link
Contributor Author

lgray commented Sep 22, 2015

Would be nice if this one can be merged soon.

@lgray
Copy link
Contributor Author

lgray commented Sep 23, 2015

@davidlange6 possible to merge this one? It is running fine in 760pre5, unless you are waiting for more validation to come through.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 23, 2015
Convert all remaining RECO & MiniAOD modules that are executed to threaded FW (75X)
@cmsbuild cmsbuild merged commit 01e471a into cms-sw:CMSSW_7_5_X Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants