Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customisations and few fixes for online DQM (75x) #10715

Merged
merged 1 commit into from Aug 14, 2015
Merged

Customisations and few fixes for online DQM (75x) #10715

merged 1 commit into from Aug 14, 2015

Conversation

dmitrijus
Copy link
Contributor

this deprecates #10563
forward port of #10714

Small set of fixes for online DQM:

  • fix the name of the online playback GUI host
  • new online GT for DQM
  • fix temporary connection string for Tau Tag high-level calibrations (ping to @diguida - oh, it's me! - and @mmusich )

few fixes for online DQM
25e423b 
(cherry picked from commit fc28909)

DQM/Integration/python/test/PlaybackInstall.patch was deleted
and changes were already merged into environment_cfi in a previous PR.

(cherry picked from commit 92047a8)
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 12, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_5_X.

Customisations and few fixes for online DQM (75x)

It involves the following packages:

DQM/Integration
RecoTauTag/Configuration

@cmsbuild, @cvuosalo, @danduggan, @deguio, @slava77 can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Aug 12, 2015

+1

@slava77
Copy link
Contributor

slava77 commented Aug 12, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 25e423b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10715/7172/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10715/7172/summary.html

@cvuosalo
Copy link
Contributor

+1

For #10715 25e423b

Fixing temporary connection string for tau tag high-level calibration, along with some online DQM fixes.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-08-10-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cvuosalo cvuosalo mentioned this pull request Aug 13, 2015
Merged
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 14, 2015
@cmsbuild
Merge pull request #10715 from dmitrijus/filesaver_pr_rebase_fc_75x
64f72e0 
Customisations and few fixes for online DQM (75x)
@cmsbuild cmsbuild merged commit 64f72e0 into cms-sw:CMSSW_7_5_X Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dmitrijus @cmsbuild @deguio @slava77 @cvuosalo @davidlange6