Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiTrackValidator cleanup #10718

Merged
merged 4 commits into from Aug 16, 2015
Merged

MultiTrackValidator cleanup #10718

merged 4 commits into from Aug 16, 2015

Conversation

makortel
Copy link
Contributor

This PR does some cleanup on MultiTrackValidator, main changes

  • Remove MTVHistoProducerAlgo base class (and the factory) as unnecessary (there is only one concrete class inheriting from it)
  • Use inique_ptr for TrackingParticle/GenParticle selectors
  • Initialize certain variables only if EDM_ML_DEBUG is defined to suppress "dead store" warnings from static analyzer

Tested in CMSSW_7_6_X_2015-08-10-2300, no changes expected in results.

@rovere @VinInn

@makortel
Remove MTVHistoProducerAlgo base class and factory
5f8a6ed 
We have only MTVHistoProducerAlgoForTracker inheriting from
MTVHistoProducerAlgo, so removing the base class and the factory eases
the maintenance.
@makortel
Use unique_ptr
179ef22
@makortel
Precalculate in fill_recoAssociated_simTrack_histos()
9430f43
@makortel
Initialize variables needed only in LogTrace only if EDM_ML_DEBUG is …
694c0f4 
…defined
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 12, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

MultiTrackValidator cleanup

It involves the following packages:

Validation/RecoTrack

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Aug 14, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor

deguio commented Aug 14, 2015

+1
thanks for the cleanup. looks good.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: 694c0f4
When I ran the RelVals I found an error in the following worklfows:
1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10718/7324/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@deguio
Copy link
Contributor

deguio commented Aug 16, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 694c0f4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10718/7368/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10718/7368/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 16, 2015
@cmsbuild
Merge pull request #10718 from makortel/mtvCleanup
971eb22 
MultiTrackValidator cleanup
@cmsbuild cmsbuild merged commit 971eb22 into cms-sw:CMSSW_7_6_X Aug 16, 2015
@makortel makortel deleted the mtvCleanup branch October 20, 2016 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makortel @cmsbuild @deguio @davidlange6